800546 - Nothing should depend on *.pyc (media/webrtc/trunk/tools/gyp/pylib/gyp/generator/mozmake.pyc)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Matěj Cepl]

When I removed all *.pyc files (just to be sure, I have changed on *.py file), build failed (building b2g with make -f client.mk build) with

make[6]: Entering directory `/home/matej/archiv/knihovna/repos/gaia/build/media/webrtc/trunk/testing'
make[6]: *** No rule to make target `/home/matej/archiv/knihovna/repos/gaia/src/media/webrtc/trunk/tools/gyp/pylib/gyp/generator/mozmake.pyc', needed by `Makefile'.  Stop.
make[6]: Leaving directory `/home/matej/archiv/knihovna/repos/gaia/build/media/webrtc/trunk/testing'

IMHO, nothing should ever depend on *.pyc (they should be disposable and generated whenever required).

Happened with mozilla-central/master in git commit 2cc089023e6a2d5ce359e25ba135d380321eae04 (repo on https://github.com/mozilla/mozilla-central).

Comment 1

[Matěj Cepl]

Most likely related to bug 685957 (which is a bit different), and bug 729752. 

I would actually advocate that make clean remove all *.pyc files in the tree.

Comment 2

[Gregory Szorc [:gps]]

It looks like the GYP-generated Makefile has a dependency on mozmake.pyc:

# Rules for regenerating Makefiles from GYP files.
Makefile: $(topsrcdir)/media/webrtc/trunk/testing/gtest.gyp $(topsrcdir)/media/webrtc/trunk/tools/gyp/pylib/gyp/generator/mozmake.pyc
    $(PYTHON) $(topsrcdir)/media/webrtc/trunk/build/gyp_chromium --format=mozmake --depth=$(topsrcdir)/media/webrtc/trunk --generator-output=$(DEPTH)/media/webrtc/trunk/tes


This is likely a bug in mozmake.py.

Comment 3

[Mike Hommey [:glandium]]

That comes from $objdir/media/webrtc/trunk/testing/common.mk, which contains something like:
Makefile: $(topsrcdir)/media/webrtc/trunk/testing/gtest.gyp $(topsrcdir)/media/webrtc/trunk/tools/gyp/pylib/gyp/generator/mozmake.pyc

This is generated by media/webrtc/trunk/tools/gyp/pylib/gyp/generator/mozmake.py, and essentially, is derived from __file__... Thanks python.

Comment 4

[(not currently active) Ted Mielczarek]

So ridiculous.

Comment 5

[Gregory Szorc [:gps]]

Attachment: Replace .py{c,o} with .py, v1

This should fix things.

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 670562 [details] [diff] [review]
Replace .py{c,o} with .py, v1

Review of attachment 670562 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/trunk/tools/gyp/pylib/gyp/generator/mozmake.py
@@ +441,5 @@
>                  swapslashes(src),
>                  swapslashes(relative_srcdir))
>    scriptname = topsrcdir_path(__file__)
> +  if scriptname[-4:] in ('.pyc', '.pyo'):
> +    scriptname = scriptname[0:len(scriptname)-1]

scriptname[:-1]

Comment 7

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c858930c3be

with scriptname[:-1] (I keep forgetting you can do that)

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1c858930c3be