Closed
Bug 800611
Opened 13 years ago
Closed 13 years ago
Remove trailing whitespace from signaling code
Categories
(Core :: WebRTC: Signaling, defect)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: ehugg, Assigned: ehugg)
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
|
2.29 MB,
patch
|
Details | Diff | Splinter Review |
Trailing whitespace gets called by splinter reviews but the signaling code already is has quite a bit. Remove all the trailing whitespace so reviews will be easier and we can all set our editors to delete trailing whitespace on save.
| Assignee | ||
Updated•13 years ago
|
Assignee: nobody → ethanhugg
| Assignee | ||
Comment 1•13 years ago
|
||
| Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 670581 [details] [diff] [review]
trailing whitespace removed from signaling code
I used this command:
sed -i -e 's/[\t ]*$//g' `find . -name '*.h' -or -name '*.c' -or -name '*.cpp' -or -name '*.cc'`
Verified that it's whitespace-only by doing:
cp -r signaling ~/tmp/signaling.org
hg qpush
diff -ur signaling ~/tmp/signaling.org
> lots of output
diff -wur signaling ~/tmp/signaling.org
> no output
Attachment #670581 -
Flags: review?(rjesup)
Updated•13 years ago
|
Attachment #670581 -
Flags: review?(rjesup) → review+
Comment 3•13 years ago
|
||
WHen I tried to apply this to inbound, I got a lot of errors. Can you rebase the patch please?
| Assignee | ||
Comment 4•13 years ago
|
||
| Assignee | ||
Updated•13 years ago
|
Attachment #670581 -
Attachment is obsolete: true
| Assignee | ||
Comment 5•13 years ago
|
||
Comment on attachment 670805 [details] [diff] [review]
Trailing whitepace removed from signaling code
Re-based on today's M-I rather than older M-C.
Attachment #670805 -
Flags: checkin?(rjesup)
Comment 6•13 years ago
|
||
Comment 7•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Updated•13 years ago
|
Attachment #670805 -
Flags: checkin?(rjesup)
Updated•13 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•