800617 - IonMonkey: Fix some ARM-specific uber-nits.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Sean Stangl [:sstangl]]

Attachment: patch

Fixes a bunch of incredibly tiny style nits within the arm/ subfolder. I had this lying around for a while, found it again recently, and might as well commit it. Nothing important whatsoever in this patch.

Comment 1

[Marty Rosenberg [:mjrosenb]]

Comment on attachment 670588 [details] [diff] [review]
patch

Review of attachment 670588 [details] [diff] [review]:
-----------------------------------------------------------------

You should make sure this compiles first.  It looks like a few important lines of code were removed.

::: js/src/ion/arm/Assembler-arm.cpp
@@ +561,1 @@
>          InstMovW *bottom = inst1->as<InstMovW>();

You sure do like removing the declaration of variables named 'top', don't you?

@@ +614,1 @@
>          InstMovW *bottom = load1->as<InstMovW>();

top was not dead, I don't think that line can be removed.

@@ +1307,1 @@
>  

Looks like mull_tag is not defined anywhere.

::: js/src/ion/arm/CodeGenerator-arm.cpp
@@ +905,1 @@
>        case JSOP_SUB:

Guess I wrote that line before I calibrated emacs' indent level?

Comment 2

[Sean Stangl [:sstangl]]

(In reply to Marty Rosenberg [:mjrosenb] from comment #1)
> You should make sure this compiles first.  It looks like a few important
> lines of code were removed.

The patch, as uploaded, compiles. Just verified to make sure.

> You sure do like removing the declaration of variables named 'top', don't
> you?
> ...
> top was not dead, I don't think that line can be removed.

It was moved; the declaration is still around.

> 
> @@ +1307,1 @@
> >  
> 
> Looks like mull_tag is not defined anywhere.

It already existed in the file.

Comment 3

[Sean Stangl [:sstangl]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e73c3d5719c5

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e73c3d5719c5