800657 - Reenable WebGL index-validation.html test

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

It was disabled by b3c814e2d015. It's not too bad, only the large-negative-value test is failing on 32bit machines. Regressed either in bug 732660 or with the porting to new bindings.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

This was regressed by:

changeset:   109965:4c134de65570
user:        Benoit Jacob <[e-mail]>
date:        Thu Oct 11 14:23:34 2012 -0400
summary:     Bug 779611 - WebGL extensions should be [NoInterfaceObject] as their compliant IDL interface names would pollute the global object - r=bz

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Erm, no, rather by

changeset:   109966:78c16f313547
user:        Benoit Jacob <[e-mail]>
date:        Thu Oct 11 15:23:03 2012 -0400
summary:     Bug 779611 - part 12: remove old-bindings remnants in the WebGL implementation - r=bz

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Yeah OK I know what this almost certainly is --- the WebGLintptr typedef was changed to a typedef to GLintptr, and likely these were not actually the same.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

OK, indeed: WebGLintptr was long long which is int64

GLintptr is ptrdiff_t.

Whence the bug on 32bit platforms

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: fix WebGL typedefs to reflect IDL types instead of being equal to OpenGL types

Again, the bug was that while most WebGL types are equal to the corresponding OpenGL type, some are different:

WebGLintptr is always long long (int64) in Web IDL while it is intptr_t in OpenGL

WebGLsizeiptr is the same

I also changed WebGLboolean to be bool, following Web IDL.

Also removed now-useless #include "WebGLContext.h" in nsDOMCI. And the #undef None there was almost certainly added there for it (X11 headers have a None macro) and affected WebGLContext.h (which has or used to have a None enum value somewhere). Removed too.

Reenabling the unit test.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 671006 [details] [diff] [review]
fix WebGL typedefs to reflect IDL types instead of being equal to OpenGL types

r=me

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/39d70a2e0dea

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/39d70a2e0dea

Comment 9

[Benoit Jacob [:bjacob] (mostly away)]

Somehow, the part of that patch that actually reenables the test was dropped. Landed now:
http://hg.mozilla.org/integration/mozilla-inbound/rev/088dfedf36d5

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/088dfedf36d5