local_dynamic_payload_type_value set and not used in gsm_sdp.c

RESOLVED FIXED in mozilla19

Status

()

Core
WebRTC: Signaling
P3
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jesup, Assigned: emannion)

Tracking

(Blocks: 1 bug)

Trunk
mozilla19
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [WebRTC], [blocking-webrtc-] [qa-])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
media/webrtc/signaling/src/sipcc/core/gsm/gsm_sdp.c
Location:	line 2834

local_dynamic_payload_type_value in gsmsdp_negotiate_codec() is set, but never used.  Likely this is a real bug, but not sure without analysis exactly what should be done.
(Reporter)

Comment 1

6 years ago
The other places it's set in there are dead assignments also
(Assignee)

Updated

6 years ago
Assignee: nobody → emannion
(Assignee)

Comment 2

6 years ago
Created attachment 672308 [details] [diff] [review]
remove local_dynamic_payload_type_value from

I removed this unused lines from negotiation,  I would like crypt to confirm that this is not breaking anything especially especially how negotiation worked when using SIP.  The unit tests are completing sucessfully.
Attachment #672308 - Flags: review?(snandaku)
Attachment #672308 - Flags: review?(ethanhugg)

Updated

6 years ago
Priority: -- → P3
Whiteboard: [WebRTC], [blocking-webrtc-]

Updated

6 years ago
Attachment #672308 - Flags: review?(ethanhugg) → review+

Comment 3

6 years ago
Comment on attachment 672308 [details] [diff] [review]
remove local_dynamic_payload_type_value from


This looks like just removal of unused code.
Attachment #672308 - Flags: review?(snandaku) → checkin?(rjesup)
https://hg.mozilla.org/mozilla-central/rev/e796f2c1121a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19

Updated

6 years ago
Attachment #672308 - Flags: checkin?(rjesup)

Updated

6 years ago
Whiteboard: [WebRTC], [blocking-webrtc-] → [WebRTC], [blocking-webrtc-] [qa-]
You need to log in before you can comment on or make changes to this bug.