media/webrtc/signaling/src/sipcc/core/gsm/gsm_sdp.c Location: line 2834 local_dynamic_payload_type_value in gsmsdp_negotiate_codec() is set, but never used. Likely this is a real bug, but not sure without analysis exactly what should be done.
The other places it's set in there are dead assignments also
Created attachment 672308 [details] [diff] [review] remove local_dynamic_payload_type_value from I removed this unused lines from negotiation, I would like crypt to confirm that this is not breaking anything especially especially how negotiation worked when using SIP. The unit tests are completing sucessfully.
Priority: -- → P3
Whiteboard: [WebRTC], [blocking-webrtc-]
Comment on attachment 672308 [details] [diff] [review] remove local_dynamic_payload_type_value from This looks like just removal of unused code.
Attachment #672308 - Flags: review?(snandaku) → checkin?(rjesup)
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Whiteboard: [WebRTC], [blocking-webrtc-] → [WebRTC], [blocking-webrtc-] [qa-]
You need to log in before you can comment on or make changes to this bug.