800689 - [System] Support modal dialogs (alert/prompt/confirm) from inline activity frames

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P2)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The fix proposed in bug 796694 requires |alert()| to work from inline activity frames. modal_dialog.js should catch the events and show the alert.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Should be blocking coz it's blocking a blocking bug.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I think we should optimistically block on this. If we start running low on time I think we should simply work around this in the pdf viewer instead.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: support modal dialog in inline-activity frame

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/pull/5820

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 671401 [details] [diff] [review]
support modal dialog in inline-activity frame

There are some potential issues here but I don't think it's a big deal.

>@@ -86,7 +89,8 @@ var ModalDialog = {
> 
>         // Show modal dialog only if
>         // the frame is currently displayed.
>-        if (origin == WindowManager.getDisplayedApp())
>+        if (origin == WindowManager.getDisplayedApp() ||
>+            frameType == 'inline-activity')
>           this.show(origin);
>         break;
> 

The "origin" (window_manager.js identifier, see bug 796629) of the inline activity frame will be same as the one for the main app frame. Relying that might mix up the dialogues a bit.

>@@ -112,6 +116,14 @@ var ModalDialog = {
>         this.show(evt.detail.origin);
>         break;
> 
>+      case 'home':
>+      case 'holdhome':
>+        // Inline activity, which origin is different from foreground app
>+        if (this.isVisible() && 
>+            this.currentOrigin != WindowManager.getDisplayedApp())
>+          this.cancelHandler();
>+        break;
>+

Don't like the special handling of the inline frame but it's not your fault. :-/

Thanks. Don't forget to paste the merging Github URL when landing the fix.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/ac94981b4972a24df2e4e995922e6013672cc00b