800703 - Rename the existing, Valgrind-based DMD as "DMDV"

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Nicholas Nethercote [inactive]]

I have a version of DMD that doesn't require Valgrind in the works (bug
717853).  My plan is for it to eventually obsolete the Valgrind-based one.
However, there will be a period of overlap where both tools are in use.  So
the point of this bug is to rename the Valgrind-based DMD as "DMDV".

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Rename the existing, Valgrind-based DMD as "DMDV".

This patch renames DMD as DMDV.  Non-trivial aspects:

- It adds a new directory, tools/dmdv.  Careful checking of the Makefile.in
  and toolkit/* changes will be appreciated.

- It moves the existing dmd.h file from xpcom/base/ to tools/dmdv/dmdv.h, a
  much better place for it.  It also removes some trailing whitespace from
  that file.

- It adds tools/dmdv/dmdv.patch, which is the patch from bug 676724.
  Because I'm not planning to develop DMDV further, having it as a patch in
  the tree seems pretty reasonable.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 670692 [details] [diff] [review]
Rename the existing, Valgrind-based DMD as "DMDV".

Review of attachment 670692 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't look at this too closely, just assumed you knew what you were doing.

Comment 3

[Nicholas Nethercote [inactive]]

You mean you didn't read dmdv.patch line by line?  I'm shocked :P

More seriously, hopefully you looked at the Makfile.in and toolkit/* changes at least a little bit.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1949f7d5c6ed

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1949f7d5c6ed

Comment 6

[Justin Lebar (not reading bugmail)]

Comment on attachment 670692 [details] [diff] [review]
Rename the existing, Valgrind-based DMD as "DMDV".

[Triage Comment]
Needed for bug 717853, npotb, and anyway just a renaming.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/d1cbbf7a3eca