Rename the existing, Valgrind-based DMD as "DMDV"

RESOLVED FIXED in Firefox 19

Status

()

Core
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla19
Points:
---

Firefox Tracking Flags

(firefox19 fixed, b2g18 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I have a version of DMD that doesn't require Valgrind in the works (bug
717853).  My plan is for it to eventually obsolete the Valgrind-based one.
However, there will be a period of overlap where both tools are in use.  So
the point of this bug is to rename the Valgrind-based DMD as "DMDV".
(Assignee)

Comment 1

5 years ago
Created attachment 670692 [details] [diff] [review]
Rename the existing, Valgrind-based DMD as "DMDV".

This patch renames DMD as DMDV.  Non-trivial aspects:

- It adds a new directory, tools/dmdv.  Careful checking of the Makefile.in
  and toolkit/* changes will be appreciated.

- It moves the existing dmd.h file from xpcom/base/ to tools/dmdv/dmdv.h, a
  much better place for it.  It also removes some trailing whitespace from
  that file.

- It adds tools/dmdv/dmdv.patch, which is the patch from bug 676724.
  Because I'm not planning to develop DMDV further, having it as a patch in
  the tree seems pretty reasonable.
Attachment #670692 - Flags: review?(khuey)
Comment on attachment 670692 [details] [diff] [review]
Rename the existing, Valgrind-based DMD as "DMDV".

Review of attachment 670692 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't look at this too closely, just assumed you knew what you were doing.
Attachment #670692 - Flags: review?(khuey) → review+
(Assignee)

Comment 3

5 years ago
You mean you didn't read dmdv.patch line by line?  I'm shocked :P

More seriously, hopefully you looked at the Makfile.in and toolkit/* changes at least a little bit.
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1949f7d5c6ed

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/1949f7d5c6ed
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Comment on attachment 670692 [details] [diff] [review]
Rename the existing, Valgrind-based DMD as "DMDV".

[Triage Comment]
Needed for bug 717853, npotb, and anyway just a renaming.
Attachment #670692 - Flags: approval-mozilla-b2g18+
https://hg.mozilla.org/releases/mozilla-b2g18/rev/d1cbbf7a3eca
status-b2g18: --- → fixed
status-firefox19: --- → fixed
You need to log in before you can comment on or make changes to this bug.