800785 - unnecessary PGO for js shell

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Makoto Kato [:m_kato]]

We don't collect PGO profiling data during profiling script for js shell (js.exe), so you should turn off PGO for js shell.

If turn off, we can save over 1 min for building PGO binary.

Comment 1

[(not currently active) Ted Mielczarek]

Should be as simple as adding this line to the Makefile:
NO_PROFILE_GUIDED_OPTIMIZE = 1

Comment 2

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 673144 [details] [diff] [review]
fix

Review of attachment 673144 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/shell/Makefile.in
@@ +18,5 @@
>    jsheaptools.cpp \
>    $(NULL)
>  
> +# unnecessary PGO for js shell
> +NO_PROFILE_GUIDED_OPTIMIZE = 1

nit: should use :=

Comment 4

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c79da81e6fc

Comment 5

[Jonathan Kew [:jfkthame]]

I backed this out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f97f6533a44

as the next PGO builds that were started (a few pushes later) burned, even after being clobbered, and this looked the likely culprit. See:
https://tbpl.mozilla.org/php/getParsedLog.php?id=16374469&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=16374555&tree=Mozilla-Inbound

Comment 6

[Makoto Kato [:m_kato]]

Attachment: fix v2

turn off PGO on MSVC only.  gcc needs PGO option when objects and static libraries and compiled by PGO option.

Comment 7

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/602add2d02e6

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/602add2d02e6

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/602add2d02e6