Closed Bug 800785 Opened 7 years ago Closed 7 years ago

unnecessary PGO for js shell

Categories

(Firefox Build System :: General, defect)

x86
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla20

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(2 files)

We don't collect PGO profiling data during profiling script for js shell (js.exe), so you should turn off PGO for js shell.

If turn off, we can save over 1 min for building PGO binary.
Should be as simple as adding this line to the Makefile:
NO_PROFILE_GUIDED_OPTIMIZE = 1
Attached patch fixSplinter Review
Assignee: nobody → m_kato
Attachment #673144 - Flags: review?(ted)
Comment on attachment 673144 [details] [diff] [review]
fix

Review of attachment 673144 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/shell/Makefile.in
@@ +18,5 @@
>    jsheaptools.cpp \
>    $(NULL)
>  
> +# unnecessary PGO for js shell
> +NO_PROFILE_GUIDED_OPTIMIZE = 1

nit: should use :=
Attachment #673144 - Flags: review?(ted) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c79da81e6fc
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla19
I backed this out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f97f6533a44

as the next PGO builds that were started (a few pushes later) burned, even after being clobbered, and this looked the likely culprit. See:
https://tbpl.mozilla.org/php/getParsedLog.php?id=16374469&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=16374555&tree=Mozilla-Inbound
Attached patch fix v2Splinter Review
turn off PGO on MSVC only.  gcc needs PGO option when objects and static libraries and compiled by PGO option.
Attachment #683008 - Flags: review?(ted)
Attachment #683008 - Flags: review?(ted) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/602add2d02e6
Target Milestone: mozilla19 → mozilla20
https://hg.mozilla.org/mozilla-central/rev/602add2d02e6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.