800840 - startup crash in XREMain::XRE_mainStartup

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Scoobidiver (away)]

It's #2 top crasher in 17.0b1.

Signature 	XREMain::XRE_mainStartup More Reports Search
UUID	917d34c7-cd00-4bfb-9ff2-820052121012
Date Processed	2012-10-12 08:14:56
Uptime	1
Install Age	1.0 minutes since version was first installed.
Install Time	2012-10-12 08:13:21
Product	FennecAndroid
Version	17.0
Build ID	20121010211745
Release Channel	beta
OS	Linux
OS Version	0.0.0 Linux 3.0.15-928452-user #1 SMP PREEMPT Tue Jul 31 19:37:49 KST 2012 armv7l
Build Architecture	arm
Build Architecture Info	
Crash Reason	SIGSEGV
Crash Address	0x0
App Notes 	
samsung GT-I9300
samsung/m0xx/m0:4.0.4/IMM76D/I9300XXBLH1:user/release-keys
Processor Notes 	WARNING: JSON file missing Add-ons
EMCheckCompatibility	False
Adapter Vendor ID	
Adapter Device ID	
Device	samsung GT-I9300
Android API Version	15 (REL)
Android CPU ABI	armeabi-v7a

Frame 	Module 	Signature 	Source
0 	libxul.so 	XREMain::XRE_mainStartup 	toolkit/xre/nsAppRunner.cpp:3445
1 	libxul.so 	XREMain::XRE_main 	toolkit/xre/nsAppRunner.cpp:3869
2 	libxul.so 	XRE_main 	toolkit/xre/nsAppRunner.cpp:3963
3 	libxul.so 	GeckoStart 	toolkit/xre/nsAndroidStartup.cpp:73
4 	libmozglue.so 	Java_org_mozilla_gecko_GeckoAppShell_nativeRun 	APKOpen.cpp:983
5 	libdvm.so 	libdvm.so@0x1ed72 	
6 	dalvik-heap (deleted) 	dalvik-heap @0xdf44c6 	
7 	libdvm.so 	libdvm.so@0x5902d 	
8 	data@[e-mail][e-mail] 	data@[e-mail][e-mail]@0x141382 	
...

More reports at:
https://crash-stats.mozilla.com/report/list?signature=XREMain%3A%3AXRE_mainStartup

Comment 1

[bhavana bajaj [:bajaj]]

Do we have any co-relations and do we see this on other any other channels ?

Comment 2

[Benjamin Smedberg]

This appears to be a null mProfileLock, which basically means that http://hg.mozilla.org/releases/mozilla-beta/annotate/f02c5fb11741/toolkit/xre/nsAppRunner.cpp#l3430 succeeded but didn't return a profile lock.

Does this have a nightly regression range?

Comment 3

[Scoobidiver (away)]

(In reply to bhavana bajaj [:bajaj] from comment #1)
> Do we have any co-relations and do we see this on other any other channels ?
Crashes happen before any loaded extensions, on Froyo, Gingerbread, ICS and JB.
Two Mac users were affected in 15.0.1.

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Does this have a nightly regression range?
No, because only Beta users and one Aurora user are affected.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Tracking for now and assigning to Benjamin - is it possible to hunt down a regression in Beta?  If you're not the right person for this please reassign to another person but if we're going to track for 17 it needs to be assigned to someone.

Comment 5

[Benjamin Smedberg]

I do not have time to look at this bug. I suspect it's something with the locked profile dialog which can't be shown on Android, but I'd like somebody from the mobile team to take it if necessary.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Alright - over to Brad then for a mobile team assessment of who can take this on.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Wes - Does this seem similar to the other bug you fixed related to locked profiles?

Comment 8

[Wesley Johnston (:wesj)]

Yes. I have a fix. testing it now

Comment 9

[Wesley Johnston (:wesj)]

Attachment: Patch

I'm not exactly sure how to reproduce this bug, but this should fix it.

Comment 10

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8596ac4d0cf

Comment 11

[Wesley Johnston (:wesj)]

Comment on attachment 672850 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 795053
User impact if declined: Crashes on startup. Subsequent starts should work
Testing completed (on m-c, etc.): Landed on mc today
Risk to taking this patch (and alternatives if risky): Medium because it gets hit during startup. This should be doing the same thing we would do in other cases where we unlock the profile for the user (i.e. a few lines above this patch).
String or UUID changes made by this patch: None.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e8596ac4d0cf

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6f7d1e8c941b
https://hg.mozilla.org/releases/mozilla-beta/rev/53675be29a2e