Closed Bug 800965 Opened 12 years ago Closed 12 years ago

Standalone image right-click menu item fails to appear using SelectorContext("img") in Addon SDK

Categories

(Add-on SDK Graveyard :: General, defect, P2)

x86
Windows XP
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mardeg, Assigned: mossop)

References

()

Details

Tested with https://addons.mozilla.org/en-us/firefox/addon/flip-or-rotate-image/ version 0.5 In Fx<17 the submenus "Flip Image" and "Rotate Image" appear in the image context menu for both normal pages and when viewing an image by itself in a tab. In Fx17 the submenus appear when right-clicking an image in a normal webpage, and they appear in existing standalone image tabs when the extension is either first installed or enabled after disabling. But reloading a standalone image tab and all subsequent loads of an image in a tab is when the submenu items fail to appear. Nothing shows up in the js error console. I still see this problem in nightly trunk builds of Firefox and building the extension with the 1.10 version of the Addon SDK. Workaround suggestions welcome.
Component: Extension Compatibility → General
Product: Firefox → Add-on SDK
Version: 17 Branch → unspecified
This is fixed by my context-menu rewrite.
Assignee: nobody → dtownsend+bugmail
Status: NEW → ASSIGNED
Depends on: 788324
The workaround used for version 0.6 of the extension was the ability to rotate images that aren't taller than the standalone tab they're in using the mousewheel. Code is at https://addons.mozilla.org/en-US/firefox/files/browse/171988/file/resources/flip-or-rotate-image/lib/main.js#L60
For version 0.6.1 of the extension the workaround was to add the contextmenu="" attribute to the <img> and add the submenus via HTML5 <menu type="context"> Code is at https://addons.mozilla.org/en-US/firefox/files/browse/172096/file/resources/flip-or-rotate-image/lib/main.js#L74
Fixed by bug 788324
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.13
You need to log in before you can comment on or make changes to this bug.