Closed Bug 801013 Opened 12 years ago Closed 12 years ago

imgRequest::AdjustPriority wrongly adjusts loadgroup instead of channel

Categories

(Core :: Graphics: ImageLib, defect)

16 Branch
x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: mcmanus, Assigned: mcmanus)

Details

Attachments

(1 file)

nsCOMPtr<nsISupportsPriority> p = do_QueryInterface(mRequest);
   if (p)
     p->AdjustPriority(delta);


mRequest is the loadgroup.. I think we want mChannel, which is specific to the image.

adjusting all members of the loadgroup creates a nop in priority for this image, and it also has a cumulative effect on the group wrt the absolute priority (i.e. if 3 members bump the priority individually then all the members of the group get 3 notches worth of priority vs other groups) which can really skew things.
Attached patch patch 0Splinter Review
Attachment #670857 - Flags: review?(joe)
Attachment #670857 - Flags: review?(joe) → review+
https://hg.mozilla.org/mozilla-central/rev/b8e7df7ac70f
Assignee: nobody → mcmanus
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: