801066 - Requesting to get the camera from a file:// URL does not show any origin of where the request is being made

Status: RESOLVED FIXED

(Firefox :: Site Permissions, defect, P3)

Description

[Jason Smith [:jsmith]]

Attachment: No Origin Shown in Doorhanger

Steps:

1. Load a request for mozGetUserMedia with video:true from a local HTML file

Expected:

The doorhanger should show the origin of the page from a file:// URL.

Actual:

No origin is seen. See screenshot.

Comment 1

[Paul Zühlcke [:pbz]]

I can still reproduce the bug. The prompt says: "Will you allow Unknown Origin to use your camera?". Other permission prompts have separate copy for this case, for example the geolocation prompt: https://searchfox.org/mozilla-central/rev/692a10e624a02fe79bf45046b586e50ea0ff17f1/browser/modules/PermissionUI.jsm#744-745

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 801066 - s/Unknown Origin/this local file/ in permission prompts when scheme is file. r?pbz

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35967f82ccb8
s/Unknown Origin/this local file/ in permission prompts when scheme is file. r=pbz,fluent-reviewers,bolsson

Comment 5

[Iulian Moraru]

Backed out for causing bc failures on browser_displayURI.js.

• Push with failures

• Failure log

• Backout link

[task 2024-01-19T00:32:02.431Z] 00:32:02     INFO - TEST-PASS | browser/base/content/test/popupNotifications/browser_displayURI.js | Check that at least the eTLD+1 is present in the markup - 
[task 2024-01-19T00:32:02.431Z] 00:32:02     INFO - Buffered messages finished
[task 2024-01-19T00:32:02.433Z] 00:32:02     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/popupNotifications/browser_displayURI.js | file:// URIs should be displayed as unknown origin. - 
[task 2024-01-19T00:32:02.434Z] 00:32:02     INFO - Stack trace:
[task 2024-01-19T00:32:02.434Z] 00:32:02     INFO - chrome://mochikit/content/browser-test.js:test_ok:1591
[task 2024-01-19T00:32:02.434Z] 00:32:02     INFO - chrome://mochitests/content/browser/browser/base/content/test/popupNotifications/browser_displayURI.js:check/<:44
[task 2024-01-19T00:32:02.434Z] 00:32:02     INFO - resource://testing-common/BrowserTestUtils.sys.mjs:withNewTab:146
[task 2024-01-19T00:32:02.434Z] 00:32:02     INFO - chrome://mochitests/content/browser/browser/base/content/test/popupNotifications/browser_displayURI.js:check:27
[task 2024-01-19T00:32:02.434Z] 00:32:02     INFO - chrome://mochitests/content/browser/browser/base/content/test/popupNotifications/browser_displayURI.js:test_displayURI_camera:116
[task 2024-01-19T00:32:02.434Z] 00:32:02     INFO - chrome://mochikit/content/browser-test.js:handleTask:1138
[task 2024-01-19T00:32:02.434Z] 00:32:02     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1210
[task 2024-01-19T00:32:02.435Z] 00:32:02     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1352
[task 2024-01-19T00:32:02.435Z] 00:32:02     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1127
[task 2024-01-19T00:32:02.435Z] 00:32:02     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-01-19T00:32:02.435Z] 00:32:02     INFO - Extension loaded
[task 2024-01-19T00:32:02.436Z] 00:32:02     INFO - GECKO(6040) | [Child 5336, Main Thread] WARNING: NS_ENSURE_TRUE(!mHasOrHasHadOwnerWindow || mOwnerWindow) failed: file /builds/worker/checkouts/gecko/dom/base/GlobalTeardownObserver.cpp:51
[task 2024-01-19T00:32:02.436Z] 00:32:02     INFO - GECKO(6040) | [Child 2476: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 10211d00 == 10 [pid = 2476] [id = 9]
[task 2024-01-19T00:32:02.437Z] 00:32:02     INFO - GECKO(6040) | [Child 2476: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 27 (eff5160) [pid = 2476] [serial = 27] [outer = 0]
[task 2024-01-19T00:32:02.437Z] 00:32:02     INFO - GECKO(6040) | [Child 2476: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 28 (10214100) [pid = 2476] [serial = 28] [outer = eff5160]
[task 2024-01-19T00:32:02.438Z] 00:32:02     INFO - GECKO(6040) | [Child 2476, Main Thread] WARNING: Fallback to FallbackRenderer: file /builds/worker/checkouts/gecko/dom/ipc/BrowserChild.cpp:2631
[task 2024-01-19T00:32:02.445Z] 00:32:02     INFO - GECKO(6040) | [Child 5336: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 555d700 == 0 [pid = 5336] [id = 0] [url = file:///Z:/task_170562270943953/build/tests/mochitest/browser/browser/base/content/test/popupNotifications]
[task 2024-01-19T00:32:02.448Z] 00:32:02     INFO - GECKO(6040) | [Child 2476: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 29 (10229d00) [pid = 2476] [serial = 29] [outer = eff5160]
[task 2024-01-19T00:32:02.469Z] 00:32:02     INFO - GECKO(6040) | [Child 5336: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (af3e500) [pid = 5336] [serial = 2] [outer = 0] [url = about:blank]
[task 2024-01-19T00:32:02.470Z] 00:32:02     INFO - GECKO(6040) | [Child 5336: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (afaa700) [pid = 5336] [serial = 3] [outer = 0] [url = file:///Z:/task_170562270943953/build/tests/mochitest/browser/browser/base/content/test/popupNotifications]
[task 2024-01-19T00:32:02.471Z] 00:32:02     INFO - GECKO(6040) | [Child 5336: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (af3adc0) [pid = 5336] [serial = 1] [outer = 0] [url = file:///Z:/task_170562270943953/build/tests/mochitest/browser/browser/base/content/test/popupNotifications]
[task 2024-01-19T00:32:02.491Z] 00:32:02     INFO - GECKO(6040) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to C:\Users\task_170562270943953\AppData\Local\Temp\tmp_ixnt_j7.mozrunner\runtests_leaks_tab_pid9736.log
[task 2024-01-19T00:32:02.499Z] 00:32:02     INFO - GECKO(6040) | [Child 2476: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 1022ac00 == 11 [pid = 2476] [id = 10]
[task 2024-01-19T00:32:02.500Z] 00:32:02     INFO - GECKO(6040) | [Child 2476: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 30 (ef90160) [pid = 2476] [serial = 30] [outer = 0]
[task 2024-01-19T00:32:02.501Z] 00:32:02     INFO - GECKO(6040) | [Child 2476: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 31 (1022bb00) [pid = 2476] [serial = 31] [outer = ef90160]
[task 2024-01-19T00:32:02.550Z] 00:32:02     INFO - GECKO(6040) | [Child 2476: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 1022c400 == 12 [pid = 2476] [id = 11]
[task 2024-01-19T00:32:02.551Z] 00:32:02     INFO - GECKO(6040) | [Child 2476: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 32 (1022fca0) [pid = 2476] [serial = 32] [outer = 0]
[task 2024-01-19T00:32:02.552Z] 00:32:02     INFO - GECKO(6040) | [Child 2476: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 33 (1027e400) [pid = 2476] [serial = 33] [outer = 1022fca0]
[task 2024-01-19T00:32:02.572Z] 00:32:02     INFO - GECKO(6040) | [Parent 9772, Main Thread] WARNING: 'aOwner->IsDiscarded()', file /builds/worker/workspace/obj-build/dist/include/mozilla/dom/SyncedContextInlines.h:95
[task 2024-01-19T00:32:02.573Z] 00:32:02     INFO - GECKO(6040) | [Child 2476: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 34 (1027ff00) [pid = 2476] [serial = 34] [outer = 1022fca0]
[task 2024-01-19T00:32:02.933Z] 00:32:02     INFO - TEST-PASS | browser/base/content/test/popupNotifications/browser_displayURI.js | Check the the extension name is present in the markup - 

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 801066 - Update browser/base/content/test/popupNotifications/browser_displayURI.js test to expect "local file" r?pbz

Depends on D197821

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04fd4c41cf6a
s/Unknown Origin/this local file/ in permission prompts when scheme is file. r=pbz,fluent-reviewers,bolsson
https://hg.mozilla.org/integration/autoland/rev/ef71d190cd57
Update browser/base/content/test/popupNotifications/browser_displayURI.js test to expect "local file" r=pbz

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/04fd4c41cf6a
https://hg.mozilla.org/mozilla-central/rev/ef71d190cd57