801083 - Remove old proxy-based list bindings

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 670930 [details] [diff] [review]
v1

Review of attachment 670930 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/nsXPConnect.cpp
@@ +1414,3 @@
>      nsISupports* supports = nullptr;
> +    mozilla::dom::UnwrapDOMObjectToISupports(aJSObj, supports);
> +    return supports;

Is this function supposed to return the canonical nsISupports pointer? I'm pretty sure this one isn't necessarily it.

Comment 2

[Boris Zbarsky [:bzbarsky]]

For Paris bindings, it needs to be the canonical one.  Any impl in which it's not is buggy.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

It isn't for nsContentList -> nsIHTMLCollection, IIRC.

Comment 4

[Peter Van der Beken [:peterv]]

(In reply to :Ms2ger from comment #1)
> Is this function supposed to return the canonical nsISupports pointer?

Yeah, I added a QI.

Comment 5

[Peter Van der Beken [:peterv]]

Attachment: v1.1

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 673453 [details] [diff] [review]
v1.1

File a followup on nuking nsIDOMHTMLPropertiesCollection altogether if we can?

I love all the code being gone.  r=me

P.S. diffstat says: "72 files changed, 181 insertions(+), 3634 deletions(-)".

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 673453 [details] [diff] [review]
v1.1

Review of attachment 673453 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsDOMClassInfo.cpp
@@ +4535,5 @@
>  
>    sDisableGlobalScopePollutionSupport =
>      Preferences::GetBool("browser.dom.global_scope_pollution.disabled");
>  
>    // Non-proxy bindings

Fix this comment

::: js/xpconnect/src/xpcpublic.h
@@ +301,5 @@
>  namespace mozilla {
>  namespace dom {
>  
>  extern int HandlerFamily;
>  inline void* ProxyFamily() { return &HandlerFamily; }

All this stuff should probably move to dom/bindings at some point.

Comment 8

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d03feda2300

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5d03feda2300

Comment 10

[Jesse Ruderman]

I'm confused. This patch removed the pref dom.new_bindings form all.js, but did not remove the code in XPCJSRuntime.cpp that uses it.