801146 - remove file from downloaded list

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Change 'delete file' to 'remove file' (no confirmation), tests

This patch implements file *removal* where the entry is removed from the downloads panel but the file remains on the file system. There seems to be ambiguity about what is expected and/or the right thing to do here. Its easy to change/put back if that's what we decide.
 
There's tests of the functionality with some minor refactoring of the other downloads tests to use new helpers. 

Patch depends on "show downloads" patch https://bug801138.bugzilla.mozilla.org/attachment.cgi?id=694149

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 694458 [details] [diff] [review]
Change 'delete file' to 'remove file' (no confirmation), tests

Review of attachment 694458 [details] [diff] [review]:
-----------------------------------------------------------------

Look good, with some minor nits that I can fix on checkin.

::: browser/metro/base/content/downloads.js
@@ +65,3 @@
>  
> +    // let title = Strings.browser.GetStringFromName("downloadsDeleteTitle");
> +    // let isConfirmed = Services.prompt.confirm(null, title, file.leafName);

Let's just delete this unused code and the associated string.

@@ +297,5 @@
>    },
>  
> +  observe: function dv_managerObserver(aSubject, aTopic, aData) {
> +    // observer-service message handler
> +    switch(aTopic) {

Minor style nit: add a space after keywords like "while" or "if" (here and below).

Comment 3

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/projects/elm/rev/457196350675

Comment 4

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.