Fixing warnings, code reorganization, separation of constant files, logger changes.
Created attachment 671034 [details] [diff] [review] Roll-up patch. v1 Rolled up from <https://github.com/mozilla-services/android-sync/pull/262> for posterity.
Summary: General cleanup to support landing product announcements → Cleanup and restructuring of Android services code to support product announcements feature
Target Milestone: --- → mozilla19
Created attachment 672199 [details] [diff] [review] Patch as landed on m-i. v2 This was reviewed by nalexander. Uploading a patch because this'll eventually need to hit Aurora to prep for Bug 793053.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Comment on attachment 672199 [details] [diff] [review] Patch as landed on m-i. v2 Requesting Aurora approval to get product announcements (Bug 774497) into Firefox 18. This is a scary looking patch size-wise (100KB), but I promise it's not! This consists of: * Moved files. * Splitting one pre-processed file into two. * Generated manifest changes. * Removing a small amount of dead code. * The only remotely significant change, which allows for per-thread log tags. This code is unit-tested, has been hand-tested, and a failure here simply results in the wrong log tag being used. The goal of this is to provide a sane platform on which to land Bug 793053.
Attachment #672199 - Flags: approval-mozilla-aurora?
Comment on attachment 672199 [details] [diff] [review] Patch as landed on m-i. v2 Approving for aurora as its been on central for a few days now
Attachment #672199 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Realized that this is dependent on Bug 798043, and the first two parts of Bug 793053 (this was filed half-way through implementing). Aurora approval flags set on those.
status-firefox18: --- → fixed
Component: Android Sync → Android Sync
Product: Mozilla Services → Android Background Services
You need to log in before you can comment on or make changes to this bug.