Cleanup and restructuring of Android services code to support product announcements feature

RESOLVED FIXED in Firefox 18

Status

()

Firefox for Android
Android Sync
RESOLVED FIXED
5 years ago
4 months ago

People

(Reporter: rnewman, Assigned: rnewman)

Tracking

unspecified
mozilla19
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox18 fixed)

Details

(Whiteboard: [snippets])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Fixing warnings, code reorganization, separation of constant files, logger changes.
(Assignee)

Comment 1

5 years ago
Created attachment 671034 [details] [diff] [review]
Roll-up patch. v1

Rolled up from <https://github.com/mozilla-services/android-sync/pull/262> for posterity.
(Assignee)

Updated

5 years ago
Blocks: 793053
(Assignee)

Updated

5 years ago
Summary: General cleanup to support landing product announcements → Cleanup and restructuring of Android services code to support product announcements feature
(Assignee)

Comment 3

5 years ago
Created attachment 672199 [details] [diff] [review]
Patch as landed on m-i. v2

This was reviewed by nalexander. Uploading a patch because this'll eventually need to hit Aurora to prep for Bug 793053.
Attachment #671034 - Attachment is obsolete: true
Attachment #672199 - Flags: review+

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/c1846c1b5c99
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Whiteboard: [snippets]
(Assignee)

Comment 5

5 years ago
Comment on attachment 672199 [details] [diff] [review]
Patch as landed on m-i. v2

Requesting Aurora approval to get product announcements (Bug 774497) into Firefox 18.

This is a scary looking patch size-wise (100KB), but I promise it's not!

This consists of:

* Moved files.
* Splitting one pre-processed file into two.
* Generated manifest changes.
* Removing a small amount of dead code.
* The only remotely significant change, which allows for per-thread log tags. This code is unit-tested, has been hand-tested, and a failure here simply results in the wrong log tag being used.

The goal of this is to provide a sane platform on which to land Bug 793053.
Attachment #672199 - Flags: approval-mozilla-aurora?
Attachment #672199 - Flags: review+
Comment on attachment 672199 [details] [diff] [review]
Patch as landed on m-i. v2

Approving for aurora as its been on central for a few days now
Attachment #672199 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Updated

5 years ago
Depends on: 798043
(Assignee)

Comment 7

5 years ago
Realized that this is dependent on Bug 798043, and the first two parts of Bug 793053 (this was filed half-way through implementing).

Aurora approval flags set on those.
Component: Android Sync → Android Sync
Product: Mozilla Services → Android Background Services

Updated

4 months ago
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.