801241 - location.href = "URL" fails in Scratchpad

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Veditz [:dveditz]]

On a Mac Nightly I get an error in the Scratchpad trying to execute

location.href = "http://www.mozilla.org"

and the location does not change.

This worked fine in an Oct 11 Nightly, and I get the errors in the Oct 12 nightly.

CC'ing bholley because he has touched the location object (in case that's the problem) and because in that range he checked in http://hg.mozilla.org/mozilla-central/rev/ab15ebccc0c0 which touches evalInSandbox().



STR:
1. Shift-F2 to open the scratchpad
2. type => 
      location.href = "http://www.mozilla.org";
3. Cmd/Ctrl-R to execute

Expected: Navigation to www.mozilla.org
Actual: error comment gets pasted into the Scratchpad

Comment 1

[Bobby Holley (:bholley)]

Attachment: Bug 801241 - Properly handle |false| return false from JS_DescribeScriptedCaller. v1

So the issue here is that JS_DescribeScriptedCaller returns false when it finds
no JS code on the stack, which we were incorrectly interpretting as an
exception.

The interesting thing here though is that there _should_ be JS code on the
stack. What's actually happening is that GetContextFromStack skips over the
top JS context (the sandbox context) because it isn't associated with a DOM
window. This seems totally wrong IMO, and I'm going to file another bug to
fix it.

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 671425 [details] [diff] [review]
Bug 801241 - Properly handle |false| return false from JS_DescribeScriptedCaller. v1

Whoops, somehow bugzilla lost the review flag. :\

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 671425 [details] [diff] [review]
Bug 801241 - Properly handle |false| return false from JS_DescribeScriptedCaller. v1

r=me

Comment 4

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ed5f4767b57

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6ed5f4767b57