801257 - System Message API: Page would wrongly handle messages to be sent to other pages

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Gene Lian (I already quit Mozilla)]

This only happens within the same App. When calling SystemMessageInternal.sendMessage(), it would send the message to all the pages that used to be registered in the _listeners[aManifestURI.spec], which is wrong. I think we need to add a check in the SystemMessageManager to handle only the message that has the matched page URI; otherwise, ignore it. This fix can also prevent this page from wrongly clearing the pending messages in other pages when sending back an acknowledgement later.

Comment 1

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

Hi Fabrice, 

Could you please review this when you have a chance? Changes are trivial. Please see comment #0 for why we need to fix that. In summary, pageA would wrongly handle the message that should be sent to pageB (within the same App).

Thanks Fabrice again!

Comment 2

[Gene Lian (I already quit Mozilla)]

Attachment: Patch 1.1

NIT: add braces for one line if-block.

Comment 3

[Gene Lian (I already quit Mozilla)]

Attachment: Patch 1.1

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/37fead15ae60

Should this have a test?

Comment 5

[Gene Lian (I already quit Mozilla)]

No, thanks. :)

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/37fead15ae60

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/137a3c517823