801284 - whine.pl should use DEFAULT_COLUMN_LIST as the default column list instead of its hardcoded list

Status: RESOLVED FIXED

(Bugzilla :: Whining, enhancement)

Description

[Frédéric Buclin]

whine.pl has:

        my @searchfields = qw(
            bug_id
            bug_severity
            priority
            rep_platform
            assigned_to
            bug_status
            resolution
            short_desc
        );

which differs from Bugzilla::Constants::DEFAULT_COLUMN_LIST:

# The default list of columns for buglist.cgi
use constant DEFAULT_COLUMN_LIST => (
    "product", "component", "assigned_to",
    "bug_status", "resolution", "short_desc", "changeddate"
);

I think both should match, and so whine.pl should use it (with bug_id prepended, of course).

Comment 1

[Edmund Wong (:ewong)]

Attachment: Use DEFAULT_COLUMN_LIST (v1)

Comment 2

[Frédéric Buclin]

Comment on attachment 775075 [details] [diff] [review]
Use DEFAULT_COLUMN_LIST (v1)

Has this patch been tested? You cannot write a bare DEFAULT_COLUMN_LIST string in qw(). Perl sees it as the string "DEFAULT_COLUMN_LIST", not as a constant.

Comment 3

[Edmund Wong (:ewong)]

Attachment: Use DEFAULT_COLUMN_LIST (v2)

Comment 4

[Edmund Wong (:ewong)]

Comment on attachment 775449 [details] [diff] [review]
Use DEFAULT_COLUMN_LIST (v2)

(Hasn't been tested.. need some help testing as w/o my patch, there are a lot of failures when doing |perl ./runtests.pl|.)

Comment 5

[Simon Green]

Comment on attachment 775449 [details] [diff] [review]
Use DEFAULT_COLUMN_LIST (v2)

Review of attachment 775449 [details] [diff] [review]:
-----------------------------------------------------------------

What you want is

my @searchfields = qw('bug_id', DEFAULT_COLUMN_LIST);

Comment 6

[Edmund Wong (:ewong)]

Attachment: Use DEFAULT_COLUMN_LIST (v3)

Comment 7

[Frédéric Buclin]

(In reply to Simon Green from comment #5)
> What you want is
> 
> my @searchfields = qw('bug_id', DEFAULT_COLUMN_LIST);

No, this is still wrong. Remove qw().

Comment 8

[Frédéric Buclin]

Comment on attachment 775455 [details] [diff] [review]
Use DEFAULT_COLUMN_LIST (v3)

>         my @searchfields = qw(
>+            'bug_id',
>+            DEFAULT_COLUMN_LIST
>         );

As long as you write qw(), variables and constants won't be interpolated. What you want is: @foo = ('bug_id', DEFAULT_...).

Comment 9

[Edmund Wong (:ewong)]

Attachment: Use DEFAULT_COLUMN_LIST (v4)

I've tested this patch on landfill and it works.

Comment 10

[Frédéric Buclin]

Comment on attachment 776941 [details] [diff] [review]
Use DEFAULT_COLUMN_LIST (v4)

>+        my @searchfields = (
>+            'bug_id',
>+            DEFAULT_COLUMN_LIST
>         );

nit: this could be written on a single line.

r=LpSolit

Comment 11

[Edmund Wong (:ewong)]

Attachment: Use DEFAULT_COLUMN_LIST (v5)

Fixed nit.

Comment 12

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified whine.pl
Committed revision 8731.

Comment 13

[Frédéric Buclin]

Added to relnotes for 5.0rc1.