mincore() call has incorrect type on tier3

RESOLVED FIXED in Firefox 18

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jan Beich, Unassigned)

Tracking

Trunk
mozilla19
x86_64
FreeBSD
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox18 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.20 KB, patch
Details | Diff | Splinter Review
(Reporter)

Description

5 years ago
Created attachment 671094 [details] [diff] [review]
reorder ifdef

AIX, Solaris and BSDs use char, not unsigned char

js/src/vm/Stack.cpp:839:18: error:
      no matching function for call to 'mincore'
    int result = mincore(base_, numBytes, vec);
                 ^~~~~~~
/usr/include/sys/mman.h:226:5: note: candidate function not viable: no known
      conversion from 'MincoreArgType *' (aka 'unsigned char *') to 'char *' for 3rd
      argument
int     mincore(const void *, size_t, char *);
        ^

Not sure
Attachment #671094 - Flags: review?(justin.lebar+bug)
Comment on attachment 671094 [details] [diff] [review]
reorder ifdef

Please update the comment.
Attachment #671094 - Flags: review?(justin.lebar+bug) → review+
(Reporter)

Comment 2

5 years ago
Created attachment 671107 [details] [diff] [review]
reorder ifdef, v2
Attachment #671094 - Attachment is obsolete: true
(Reporter)

Updated

5 years ago
Attachment #671107 - Flags: checkin?(justin.lebar+bug)
Do you need this fixed in Aurora as well?  If so, please nom the patch.

https://hg.mozilla.org/integration/mozilla-inbound/rev/34b1f3ed8113
Comment on attachment 671107 [details] [diff] [review]
reorder ifdef, v2

Just stick with checkin-needed :)
Attachment #671107 - Flags: checkin?(justin.lebar+bug)
Keywords: checkin-needed
(In reply to Ryan VanderMeulen from comment #4)
> Just stick with checkin-needed :)

Sometimes I think we add features to bugzilla just to confuse people...
Keywords: checkin-needed
I'm not entirely sure if it was the reason why checkin? was added in the first place, but I find it most useful for situations when there are multiple patches attached to a bug and only a subset is landing at a given time. Makes it much easier to make sense of what landed when or what needs checking in. But for bugs when everything's landing at once, it doesn't serve much of a purpose.
(Reporter)

Comment 7

5 years ago
Comment on attachment 671107 [details] [diff] [review]
reorder ifdef, v2

(In reply to Justin Lebar [:jlebar] from comment #3)
> Do you need this fixed in Aurora as well?  If so, please nom the patch.
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/34b1f3ed8113

:gaston would be upset if I don't. ;)

[Approval Request Comment]
Risk to taking this patch: broken build on tier1, similar to comment #0
Attachment #671107 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/34b1f3ed8113
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Attachment #671107 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/95606da2eaa0

Thanks jan for fixing it, it was on my todo :)
(Reporter)

Updated

5 years ago
status-firefox18: --- → fixed
You need to log in before you can comment on or make changes to this bug.