801295 - mincore() call has incorrect type on tier3

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan Beich]

Attachment: reorder ifdef

AIX, Solaris and BSDs use char, not unsigned char

js/src/vm/Stack.cpp:839:18: error:
      no matching function for call to 'mincore'
    int result = mincore(base_, numBytes, vec);
                 ^~~~~~~
/usr/include/sys/mman.h:226:5: note: candidate function not viable: no known
      conversion from 'MincoreArgType *' (aka 'unsigned char *') to 'char *' for 3rd
      argument
int     mincore(const void *, size_t, char *);
        ^

Not sure

Comment 1

[Justin Lebar (not reading bugmail)]

Comment on attachment 671094 [details] [diff] [review]
reorder ifdef

Please update the comment.

Comment 2

[Jan Beich]

Attachment: reorder ifdef, v2

Comment 3

[Justin Lebar (not reading bugmail)]

Do you need this fixed in Aurora as well?  If so, please nom the patch.

https://hg.mozilla.org/integration/mozilla-inbound/rev/34b1f3ed8113

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 671107 [details] [diff] [review]
reorder ifdef, v2

Just stick with checkin-needed :)

Comment 5

[Justin Lebar (not reading bugmail)]

(In reply to Ryan VanderMeulen from comment #4)
> Just stick with checkin-needed :)

Sometimes I think we add features to bugzilla just to confuse people...

Comment 6

[Ryan VanderMeulen [:RyanVM]]

I'm not entirely sure if it was the reason why checkin? was added in the first place, but I find it most useful for situations when there are multiple patches attached to a bug and only a subset is landing at a given time. Makes it much easier to make sense of what landed when or what needs checking in. But for bugs when everything's landing at once, it doesn't serve much of a purpose.

Comment 7

[Jan Beich]

Comment on attachment 671107 [details] [diff] [review]
reorder ifdef, v2

(In reply to Justin Lebar [:jlebar] from comment #3)
> Do you need this fixed in Aurora as well?  If so, please nom the patch.
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/34b1f3ed8113

:gaston would be upset if I don't. ;)

[Approval Request Comment]
Risk to taking this patch: broken build on tier1, similar to comment #0

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/34b1f3ed8113

Comment 9

[Landry Breuil (:gaston)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/95606da2eaa0

Thanks jan for fixing it, it was on my todo :)