801348 - `selection` listeners are not removed when the add-on is disabled / uninstalled

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Matteo Ferretti [:zer0] [:matteo]]

The code above:

  require("selection").on("select", function(){
    console.log(this.text);
  });

Is still running for the documents it was applied, even if the user disable / uninstall the add-on. Not sure if it's a regression, or it was always like that.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Can you see when this broke?

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

I checked with SDK 1.10, and the issue is present there as well. As far as I can remember, we never explicitly remove the listeners when the add-on was disabled/uninstalled since I joined Mozilla. It means that probably we use tab-browser's tracker for that, but something probably changed in tracker or selection code that makes it not working anymore as expected. However because tab-tracker is deprecated, we didn't found / fix it earlier.