Open Bug 801357 Opened 7 years ago Updated 11 months ago

Remove nsIScriptContext::Get/SetProcessingScriptTag()

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

REOPENED
mozilla19

People

(Reporter: torisugari, Assigned: torisugari)

References

(Depends on 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No one uses Get/SetProcessingScriptTag() unless bug 754029 backouts.
Attached patch p (obsolete) — Splinter Review
Comment on attachment 671158 [details] [diff] [review]
p

I'm not too sure when to land though. A few days?
Attachment #671158 - Flags: review?(bugs)
Comment on attachment 671158 [details] [diff] [review]
p

Review of attachment 671158 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsScriptLoader.cpp
@@ -854,5 @@
>  
>    JSContext *cx = nullptr; // Initialize this to keep GCC happy.
>    cx = context->GetNativeContext();
>    JSAutoRequest ar(cx);
> -  context->SetProcessingScriptTag(oldProcessingScriptTag);

You can also remove the three lines above this one.
Attachment #671158 - Flags: review?(bugs) → review+
Attached patch patch v2Splinter Review
Thanks. Now all I understand is JSAutoRequest() is very mysterious...
Attachment #671158 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/2723a3d9fdd8
Assignee: nobody → torisugari
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2723a3d9fdd8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
(In reply to O. Atsushi (Torisugari) from comment #0)
> No one uses Get/SetProcessingScriptTag() unless bug 754029 backouts.

Which it was: https://hg.mozilla.org/mozilla-central/rev/b695e94363b5
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.