801357 - Remove nsIScriptContext::Get/SetProcessingScriptTag()

Status: REOPENED

(Core :: DOM: Core & HTML, defect)

Description

[O. Atsushi (Torisugari)]

No one uses Get/SetProcessingScriptTag() unless bug 754029 backouts.

Comment 1

[O. Atsushi (Torisugari)]

Attachment: p

Comment 2

[O. Atsushi (Torisugari)]

Comment on attachment 671158 [details] [diff] [review]
p

I'm not too sure when to land though. A few days?

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 671158 [details] [diff] [review]
p

Review of attachment 671158 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsScriptLoader.cpp
@@ -854,5 @@
>  
>    JSContext *cx = nullptr; // Initialize this to keep GCC happy.
>    cx = context->GetNativeContext();
>    JSAutoRequest ar(cx);
> -  context->SetProcessingScriptTag(oldProcessingScriptTag);

You can also remove the three lines above this one.

Comment 4

[O. Atsushi (Torisugari)]

Attachment: patch v2

Thanks. Now all I understand is JSAutoRequest() is very mysterious...

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2723a3d9fdd8

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2723a3d9fdd8

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to O. Atsushi (Torisugari) from comment #0)
> No one uses Get/SetProcessingScriptTag() unless bug 754029 backouts.

Which it was: https://hg.mozilla.org/mozilla-central/rev/b695e94363b5

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.