801391 - A clipboard will be overwritten if a focus is moved to the form for search of Library

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Hideo Oshima]

Steps to reproduce:
1. Open Library and input aaa to "Search Bookmarks"
2. Click anywhere a list in the right pane to move the focus out of "Serach Bookmarks"
3. Select a text from Firefox content area, for example bbb
4. Click "Search Bookmarks" of Library and paste from clip board by middle click

Actual result:
Paste aaa

Expected result:
Paste bbb

This originally reported to bugizlla-jp.
http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=6833

Comment 1

[Alice0775 White]

When I click "Search Box" in Library atStep4, the previously search term is selected, so the PRIMARY will be overwrited.

I think that the problem is  clickSelectsAll="true" in
http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/places.xul#332

Comment 2

[Elbart]

Is this Linux-only? Can't reproduce in Windows.

Comment 3

[Hideo Oshima]

(In reply to Elbart from comment #2)
> Is this Linux-only? Can't reproduce in Windows.

Yes, I think so.
Because You can't copy the string by the way that I reported.(STR No.2)

Comment 4

[Mark Banner (:standard8)]

It looks we should set clickSelectsAll based on the browser.urlbar.clickSelectsAll pref. This is set to false for Linux & true for other platforms (probably for this exact type of issue).

Comment 5

[Mark Banner (:standard8)]

I have a patch for this, test linux build is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ff95b457fc0e5d98b20dc04d188e3cecdf12c18&selectedJob=158689883

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 801391 - Set clickSelectsAll depending on the preference for the Bookmarks Library search box.

Review commit: https://reviewboard.mozilla.org/r/215940/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215940/

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 8945830 [details]
Bug 801391 - Set clickSelectsAll depending on the preference for the Bookmarks Library search box.

https://reviewboard.mozilla.org/r/215940/#review221746

worth a try.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4bfdf6b1d4a9
Set clickSelectsAll depending on the preference for the Bookmarks Library search box. r=mak

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4bfdf6b1d4a9

Comment 10

[Hideo Oshima]

I confirmed this bug has been fixed.
Thanks!