Closed Bug 80147 Opened 24 years ago Closed 23 years ago

[XBL] Use XUL prototype elements for all XUL elements in an XBL document

Categories

(Core :: XBL, defect)

Product:
Core
Component:
XBL
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla0.9.6

People

(Reporter: hyatt, Assigned: hyatt)

References

Details

(Keywords: memory-footprint, perf)

Attachments

(1 file)

Here it is!
15.65 KB, patch
dbaron
: review+
jst
: superreview+
Details | Diff | Splinter Review
If XUL elements in an XBL file used prototypes, then the act of doing CloneNode inside GenerateAnonymousContent would become much cheaper.
I don't expect to fix this in 0.9.1, but it's one of my top priorities for overal performance improvements. so focusing on it now.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.1
Blocks: 49141
moving to 0.9.2 since this will be aimed at 0.9.2
Target Milestone: mozilla0.9.1 → mozilla0.9.2
any ideas on what kind of improvement we expect to see this make?
adding PDT+
Whiteboard: [PDT+]
moving to 0.9.3
Target Milestone: mozilla0.9.2 → mozilla0.9.3
What gets affected by this change in mail? Is this still PDT+?
Keywords: perf
Whiteboard: [PDT+]
moving to 0.9.4
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Going to take this back since I see it slipping and there hasn't been much activity.
Assignee: sspitzer → hyatt
Status: ASSIGNED → NEW
hyatt, thanks for taking it back. Sorry for never getting to it. You're clearly a better owner for this bug.
Status: NEW → ASSIGNED
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Target Milestone: mozilla0.9.6 → mozilla0.9.7
Cruelly foisting this onto shaver.
Assignee: hyatt → shaver
Status: ASSIGNED → NEW
Insidiously retargeting for shaver.
Target Milestone: mozilla0.9.7 → mozilla0.9.6
Blocks: 104400
Keywords: footprint
10/25 Perf Meeting: hyatt is taking this bug back, due to the fact that he is working on bug 106153
Assignee: shaver → hyatt
Attached patch Here it is! — — Splinter Review
Comment on attachment 56389 [details] [diff] [review] Here it is! sr=jst (with some minor changes hyatt already made).
Attachment #56389 - Flags: superreview+
Comment on attachment 56389 [details] [diff] [review] Here it is! r=dbaron (with changes discussed on IRC)
Attachment #56389 - Flags: review+
Fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: