[XBL] Use XUL prototype elements for all XUL elements in an XBL document

RESOLVED FIXED in mozilla0.9.6

Status

()

defect
RESOLVED FIXED
18 years ago
5 years ago

People

(Reporter: hyatt, Assigned: hyatt)

Tracking

(Blocks 1 bug, {memory-footprint, perf})

Trunk
mozilla0.9.6
x86
Windows 2000
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

18 years ago
If XUL elements in an XBL file used prototypes, then the act of doing CloneNode 
inside GenerateAnonymousContent would become much cheaper.
I don't expect to fix this in 0.9.1, but it's one of my top priorities for 
overal performance improvements.  so focusing on it now.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.1

Updated

18 years ago
Blocks: 49141

Comment 2

18 years ago
moving to 0.9.2 since this will be aimed at 0.9.2
Target Milestone: mozilla0.9.1 → mozilla0.9.2

Comment 3

18 years ago
any ideas on what kind of improvement we expect to see this make?

Comment 4

18 years ago
adding PDT+
Whiteboard: [PDT+]

Comment 5

18 years ago
moving to 0.9.3
Target Milestone: mozilla0.9.2 → mozilla0.9.3

Comment 6

18 years ago
What gets affected by this change in mail?   Is this still PDT+?
Keywords: perf

Updated

18 years ago
Whiteboard: [PDT+]

Comment 7

18 years ago
moving to 0.9.4
Target Milestone: mozilla0.9.3 → mozilla0.9.4
(Assignee)

Comment 8

18 years ago
Going to take this back since I see it slipping and there hasn't been much activity.
Assignee: sspitzer → hyatt
Status: ASSIGNED → NEW
hyatt, thanks for taking it back.  Sorry for never getting to it.

You're clearly a better owner for this bug.
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
Target Milestone: mozilla0.9.4 → mozilla0.9.5
(Assignee)

Updated

18 years ago
Target Milestone: mozilla0.9.5 → mozilla0.9.6
(Assignee)

Updated

18 years ago
Target Milestone: mozilla0.9.6 → mozilla0.9.7
(Assignee)

Comment 10

18 years ago
Cruelly foisting this onto shaver.
Assignee: hyatt → shaver
Status: ASSIGNED → NEW
(Assignee)

Comment 11

18 years ago
Insidiously retargeting for shaver.
Target Milestone: mozilla0.9.7 → mozilla0.9.6

Updated

18 years ago
Blocks: 104400
Keywords: footprint

Comment 12

18 years ago
10/25 Perf Meeting:

hyatt is taking this bug back, due to the fact that he is working on bug 106153
Assignee: shaver → hyatt
(Assignee)

Comment 13

18 years ago
Posted patch Here it is!Splinter Review
Comment on attachment 56389 [details] [diff] [review]
Here it is!

sr=jst (with some minor changes hyatt already made).
Attachment #56389 - Flags: superreview+
Comment on attachment 56389 [details] [diff] [review]
Here it is!

r=dbaron (with changes discussed on IRC)
Attachment #56389 - Flags: review+
(Assignee)

Comment 16

18 years ago
Fixed.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.