801477 - Regression: Black flash on startup

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

It looks like bug 770047 has returned with a quick black screen flash on cold startup, at least for me on my Galaxy Nexus (Android 4.1.1) and Nexus 7 (Android 4.1.2).

--
Tested via Nightly (10/14)

Comment 1

[Aaron Train [:aaronmt]]

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=90857937b601&tochange=0be7bfea4744

Looks like either bug 772940 or bug 767980 

Lucas, do you see this?

Comment 2

[Lucas Rocha (:lucasr)]

FYI: this is probably caused by http://hg.mozilla.org/mozilla-central/rev/2e416d28e933

Need to find a way to avoid the black flash when SurfaceView is first added to the layout.

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Fix black flash on startup caused by SurfaceView

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 672355 [details] [diff] [review]
Fix black flash on startup caused by SurfaceView

Review of attachment 672355 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks for fixing this, it was really annoying! :)

Comment 6

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/414f6660e118

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/414f6660e118

Comment 8

[Andreea Pod]

No black screen flash on cold startup, marking as verified fixed.

Build: Firefox for Android 19.0a1 (2012-10-30), Firefox for Android 18.0a2 (2012-10-30)
Device: Samsung Galaxy Nexus
OS: Android 4.1.2

Comment 9

[Lucas Rocha (:lucasr)]

Comment on attachment 672355 [details] [diff] [review]
Fix black flash on startup caused by SurfaceView

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 767980
User impact if declined: Black flash on startup.
Testing completed (on m-c, etc.): A few weeks in m-c, no issues.
Risk to taking this patch (and alternatives if risky): Small change, that has been in m-c for a few weeks now.
String or UUID changes made by this patch: none

Comment 10

[bhavana bajaj [:bajaj]]

Comment on attachment 672355 [details] [diff] [review]
Fix black flash on startup caused by SurfaceView

As discussed offline with Lucas and Release Management team, we will have the entire tab UX improvements ride the trains.