801483 - make nsBufferedInputStream::Init fallible

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Makoto Kato [:m_kato]]

crash id is bp-f7294fd5-e5d4-4c5f-81ea-86b722121012 .

I think that nsIBufferedInputStream.init should return out of memory error if buffer parameter is too big or we cannot allocate memory.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Please change NS_NewBufferedInputStream to have MOZ_WARN_UNUSED_RESULT, and change the callers of NS_NewBufferedInputStream to handle the error correctly and/or forward the correct error code. I noticed three problems:

#1: Will crash because the code assumes NS_NewBufferedInputStream always succeeds:
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsPresShell.cpp#8117

#2, #3: Returns the wrong error code:
http://mxr.mozilla.org/mozilla-central/source/netwerk/cache/nsDiskCacheDeviceSQL.cpp#1747
http://mxr.mozilla.org/mozilla-central/source/dom/devicestorage/nsDeviceStorage.cpp#362

Comment 3

[Makoto Kato [:m_kato]]

(In reply to Brian Smith (:bsmith) from comment #2)
> Please change NS_NewBufferedInputStream to have MOZ_WARN_UNUSED_RESULT, and
> change the callers of NS_NewBufferedInputStream to handle the error
> correctly and/or forward the correct error code. I noticed three problems:
> 
> #1: Will crash because the code assumes NS_NewBufferedInputStream always
> succeeds:
> http://mxr.mozilla.org/mozilla-central/source/layout/base/nsPresShell.
> cpp#8117
> 
> #2, #3: Returns the wrong error code:
> http://mxr.mozilla.org/mozilla-central/source/netwerk/cache/
> nsDiskCacheDeviceSQL.cpp#1747
> http://mxr.mozilla.org/mozilla-central/source/dom/devicestorage/
> nsDeviceStorage.cpp#362

OK. I will fix this.

Comment 4

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 5

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 6

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 671349 [details] [diff] [review]
fix

Review of attachment 671349 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review because Honza is OOO this week.

Comment 7

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e0ef3f66290

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6e0ef3f66290