Closed Bug 801498 Opened 7 years ago Closed 7 years ago

Bug 798040 uglified about:compartments

Categories

(Toolkit :: about:memory, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19
Tracking Status
firefox18 --- fixed

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

Details

Attachments

(1 file)

I apparently regressed about:compartments styling.  Oops.
Attached patch Patch, v1Splinter Review
Attachment #671564 - Flags: review?(n.nethercote)
In lieu of a screenshot, I'll say: This make about:compartments look like you'd expect.  :)
Assignee: nobody → justin.lebar+bug
Note to self: We'll need this on Aurora too.
Attachment #671564 - Flags: review?(n.nethercote) → review+
Comment on attachment 671564 [details] [diff] [review]
Patch, v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 798040
User impact if declined: Fully-functional but ugly about:compartments
Testing completed (on m-c, etc.): I ran it locally...
Risk to taking this patch (and alternatives if risky): Risk is that I somehow break about:compartments more than it's already broken, which seems unlikely.
String or UUID changes made by this patch: None.
Attachment #671564 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/8d1b4a1f42ea
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Attachment #671564 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.