801545 - Remove obsolete attribute: DocumentType.internalSubset

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

These are on the DOM spec's kill-list.  IE/Chrome/Opera both also seem to support internalSubset, and IE/Chrome support inputEncoding (but Opera does not).  Probably no one much uses them, but if they do, they're not callable, so they'll just return undefined and probably not break the page.

This is tested already by dom/imptests/webapps/DOMCore/tests/submissions/Ms2ger/test_historical.html.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

So a couple of wrinkles:

1) We don't want to stop supporting the *idea* of internal subsets, just stop exposing them via .internalSubset, right?  If so, what do we do about internal users (like XML serializers) that want to know about internal subsets?  Should .internalSubset just be made non-scriptable, perhaps, or maybe non-XPCOM if I can get away with it?

2) Our XHR implementation and some tests seem to deliberately use .inputEncoding instead of .characterSet.  Can all these uses be converted to .characterSet instead, or is the distinction actually important?

This possibly warrants being two separate bugs.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Document.inputEncoding is back.

Comment 3

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ce4fff7fcf8

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8672383 [details] [diff] [review]
Patch

What is the state of support for this in other browsers today?

Have you sent an intent to remove/unship mail about this?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8672383 [details] [diff] [review]
Patch

Removing review request for now pending answers to my questions.

Comment 6

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Comment on attachment 8672383 [details] [diff] [review]
Patch

Chrome removed it, seemingly over a year ago.  IE still supports it.  I posted to dev-platform just now.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8672383 [details] [diff] [review]
Patch

OK, r=me if there are no objections on .platform in a day or three.

Comment 8

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

needinfoing jgraham to do the checkin in a couple of days if there are no objections on dev-platform.

Comment 9

[James Graham [:jgraham]]

I don't see any objections, so I'll push this.

Comment 10

[James Graham [:jgraham]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/457e2b6d6e2a62351ea12ec782cb1ade1fd1bb08
Bug 801545 - Remove DocumentType.internalSubset, r=bz

Comment 11

[James Graham [:jgraham]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9eb54c6df8010f528b06a4a029907d5aacd86055
Bug 801545 - Fix broken json file in test metadata added by previous patch, a=testonly

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/457e2b6d6e2a
https://hg.mozilla.org/mozilla-central/rev/9eb54c6df801

Comment 13

[Kohei Yoshino [:kohei]]

Added the site compatibility doc just in case: https://www.fxsitecompat.com/en-US/docs/2015/documenttype-internalsubset-has-been-removed/

Comment 14

[Jean-Yves Perrier [:teoli]]

Added a mention: https://developer.mozilla.org/en-US/Firefox/Releases/44#DOM_HTML_DOM

The property was not documented in MDN, so nothing more to do.