Remove obsolete attribute: DocumentType.internalSubset

RESOLVED FIXED in Firefox 44

Status

()

enhancement
RESOLVED FIXED
7 years ago
a month ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

({dev-doc-complete, site-compat})

Trunk
mozilla44
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox44 fixed)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment)

These are on the DOM spec's kill-list.  IE/Chrome/Opera both also seem to support internalSubset, and IE/Chrome support inputEncoding (but Opera does not).  Probably no one much uses them, but if they do, they're not callable, so they'll just return undefined and probably not break the page.

This is tested already by dom/imptests/webapps/DOMCore/tests/submissions/Ms2ger/test_historical.html.
Flags: in-testsuite+
So a couple of wrinkles:

1) We don't want to stop supporting the *idea* of internal subsets, just stop exposing them via .internalSubset, right?  If so, what do we do about internal users (like XML serializers) that want to know about internal subsets?  Should .internalSubset just be made non-scriptable, perhaps, or maybe non-XPCOM if I can get away with it?

2) Our XHR implementation and some tests seem to deliberately use .inputEncoding instead of .characterSet.  Can all these uses be converted to .characterSet instead, or is the distinction actually important?

This possibly warrants being two separate bugs.
Assignee: ayg → nobody
Status: ASSIGNED → NEW
Document.inputEncoding is back.
Summary: Remove obsolete attributes: Document.inputEncoding, DocumentType.internalSubset → Remove obsolete attribute: DocumentType.internalSubset

Updated

4 years ago
Whiteboard: '

Updated

4 years ago
Whiteboard: ' → [good first bug]

Updated

4 years ago
Keywords: dev-doc-needed
Posted patch PatchSplinter Review
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ce4fff7fcf8
Assignee: nobody → ayg
Status: NEW → ASSIGNED
Attachment #8672383 - Flags: review?(bzbarsky)
Comment on attachment 8672383 [details] [diff] [review]
Patch

What is the state of support for this in other browsers today?

Have you sent an intent to remove/unship mail about this?
Flags: needinfo?(ayg)
Comment on attachment 8672383 [details] [diff] [review]
Patch

Removing review request for now pending answers to my questions.
Attachment #8672383 - Flags: review?(bzbarsky)
Comment on attachment 8672383 [details] [diff] [review]
Patch

Chrome removed it, seemingly over a year ago.  IE still supports it.  I posted to dev-platform just now.
Flags: needinfo?(ayg)
Attachment #8672383 - Flags: review?(bzbarsky)
Comment on attachment 8672383 [details] [diff] [review]
Patch

OK, r=me if there are no objections on .platform in a day or three.
Attachment #8672383 - Flags: review?(bzbarsky) → review+
needinfoing jgraham to do the checkin in a couple of days if there are no objections on dev-platform.
Flags: needinfo?(james)
I don't see any objections, so I'll push this.
Flags: needinfo?(james)
https://hg.mozilla.org/integration/mozilla-inbound/rev/9eb54c6df8010f528b06a4a029907d5aacd86055
Bug 801545 - Fix broken json file in test metadata added by previous patch, a=testonly
https://hg.mozilla.org/mozilla-central/rev/457e2b6d6e2a
https://hg.mozilla.org/mozilla-central/rev/9eb54c6df801
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Added a mention: https://developer.mozilla.org/en-US/Firefox/Releases/44#DOM_HTML_DOM

The property was not documented in MDN, so nothing more to do.
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.