Closed Bug 801545 Opened 8 years ago Closed 5 years ago
Remove obsolete attribute: Document
Type .internal Subset
These are on the DOM spec's kill-list. IE/Chrome/Opera both also seem to support internalSubset, and IE/Chrome support inputEncoding (but Opera does not). Probably no one much uses them, but if they do, they're not callable, so they'll just return undefined and probably not break the page. This is tested already by dom/imptests/webapps/DOMCore/tests/submissions/Ms2ger/test_historical.html.
So a couple of wrinkles: 1) We don't want to stop supporting the *idea* of internal subsets, just stop exposing them via .internalSubset, right? If so, what do we do about internal users (like XML serializers) that want to know about internal subsets? Should .internalSubset just be made non-scriptable, perhaps, or maybe non-XPCOM if I can get away with it? 2) Our XHR implementation and some tests seem to deliberately use .inputEncoding instead of .characterSet. Can all these uses be converted to .characterSet instead, or is the distinction actually important? This possibly warrants being two separate bugs.
Assignee: ayg → nobody
Status: ASSIGNED → NEW
Document.inputEncoding is back.
Summary: Remove obsolete attributes: Document.inputEncoding, DocumentType.internalSubset → Remove obsolete attribute: DocumentType.internalSubset
Assignee: nobody → ayg
Status: NEW → ASSIGNED
Comment on attachment 8672383 [details] [diff] [review] Patch What is the state of support for this in other browsers today? Have you sent an intent to remove/unship mail about this?
Comment on attachment 8672383 [details] [diff] [review] Patch Removing review request for now pending answers to my questions.
Comment on attachment 8672383 [details] [diff] [review] Patch Chrome removed it, seemingly over a year ago. IE still supports it. I posted to dev-platform just now.
Comment on attachment 8672383 [details] [diff] [review] Patch OK, r=me if there are no objections on .platform in a day or three.
Attachment #8672383 - Flags: review?(bzbarsky) → review+
needinfoing jgraham to do the checkin in a couple of days if there are no objections on dev-platform.
I don't see any objections, so I'll push this.
https://hg.mozilla.org/integration/mozilla-inbound/rev/457e2b6d6e2a62351ea12ec782cb1ade1fd1bb08 Bug 801545 - Remove DocumentType.internalSubset, r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/9eb54c6df8010f528b06a4a029907d5aacd86055 Bug 801545 - Fix broken json file in test metadata added by previous patch, a=testonly
Added the site compatibility doc just in case: https://www.fxsitecompat.com/en-US/docs/2015/documenttype-internalsubset-has-been-removed/
Added a mention: https://developer.mozilla.org/en-US/Firefox/Releases/44#DOM_HTML_DOM The property was not documented in MDN, so nothing more to do.
You need to log in before you can comment on or make changes to this bug.