If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Build fails if debug is disabled but dump-painting is enabled

RESOLVED FIXED in mozilla19

Status

()

Product:
Core
Component:
Layout
RESOLVED FIXED
Reported:
5 years ago
Modified:
5 years ago

People

(Reporter: cwiiis, Assigned: cwiiis)

Tracking

({regression})

Version:
Trunk
Target:
mozilla19
Keywords:
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Fix building with --disable-debug and --enable-dump-painting
995 bytes, patch
mattwoodrow
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
5 years ago 
As titled, if you specify --disable-debug and --enable-dump-painting in your mozconfig, the build will fail with:

layout/base/FrameLayerBuilder.cpp: In function 'void mozilla::PaintInactiveLayer(nsDisplayListBuilder*, mozilla::layers::LayerManager*, nsDisplayItem*, gfxContext*, nsRenderingContext*)':
layout/base/FrameLayerBuilder.cpp:1947: error: 'AppUnitsPerDevPixel' was not declared in this scope
(Assignee)

Comment 1

•
5 years ago 
Created attachment 671360 [details] [diff] [review]
Fix building with --disable-debug and --enable-dump-painting
Attachment #671360 - Flags: review?(matt.woodrow)
(Assignee)

Comment 2

•
5 years ago 
This is a regression caused by bug 799407.
Blocks: 799407
Keywords: regression
Attachment #671360 - Flags: review?(matt.woodrow) → review+
 (Assignee)

Comment 3

•
5 years ago 
Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/f4b63574e768

Comment 4

•
5 years ago 
https://hg.mozilla.org/mozilla-central/rev/f4b63574e768
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.