remove code specific to OS X 10.5 in Cocoa widgets

RESOLVED FIXED in mozilla19

Status

()

Core
Widget: Cocoa
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

Trunk
mozilla19
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

31.86 KB, patch
smichaud
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 671399 [details] [diff] [review]
fix v1.0

Pretty straightforward patch. This also removes some code in widget specific to Carbon NPAPI plugins.
Attachment #671399 - Flags: review?(smichaud)
(Assignee)

Comment 1

5 years ago
Created attachment 676154 [details] [diff] [review]
fix v1.1

Update to current trunk.
Attachment #671399 - Attachment is obsolete: true
Attachment #671399 - Flags: review?(smichaud)
Attachment #676154 - Flags: review?(smichaud)
Attachment #676154 - Flags: review?(smichaud) → review+
(Assignee)

Comment 2

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=eef8a8bfef4c
(Assignee)

Comment 3

5 years ago
pushed to mozilla-inbound

http://hg.mozilla.org/integration/mozilla-inbound/rev/eef85b630817
Comment on attachment 676154 [details] [diff] [review]
fix v1.1

Review of attachment 676154 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsCocoaFeatures.mm
@@ +45,5 @@
>  {
>      // Disallow Core Animation on 10.5 because of crashes.
>      // See Bug 711564.
>      return (OSXVersion() >= MAC_OS_X_VERSION_10_6_HEX);
>  }

It looks like nsCocoaFeatures::SupportCoreAnimationPlugins could also have been removed from here (and its callers simplified to just use 'true').

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/eef85b630817
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.