remove code specific to OS X 10.5 in Cocoa widgets

RESOLVED FIXED in mozilla19

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jaas, Assigned: jaas)

Tracking

Trunk
mozilla19
All
macOS
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

31.86 KB, patch
smichaud
: review+
Details | Diff | Splinter Review
Posted patch fix v1.0 (obsolete) — Splinter Review
Pretty straightforward patch. This also removes some code in widget specific to Carbon NPAPI plugins.
Attachment #671399 - Flags: review?(smichaud)
Posted patch fix v1.1Splinter Review
Update to current trunk.
Attachment #671399 - Attachment is obsolete: true
Attachment #671399 - Flags: review?(smichaud)
Attachment #676154 - Flags: review?(smichaud)
Attachment #676154 - Flags: review?(smichaud) → review+
Comment on attachment 676154 [details] [diff] [review]
fix v1.1

Review of attachment 676154 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsCocoaFeatures.mm
@@ +45,5 @@
>  {
>      // Disallow Core Animation on 10.5 because of crashes.
>      // See Bug 711564.
>      return (OSXVersion() >= MAC_OS_X_VERSION_10_6_HEX);
>  }

It looks like nsCocoaFeatures::SupportCoreAnimationPlugins could also have been removed from here (and its callers simplified to just use 'true').
https://hg.mozilla.org/mozilla-central/rev/eef85b630817
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.