Closed Bug 801646 Opened 8 years ago Closed 8 years ago

PBM - Tab opened from other private browse tabs should become a private browse one

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 20
Tracking Status
firefox20 --- verified

People

(Reporter: tetsuharu, Assigned: bnicholson)

References

Details

(Keywords: ux-userfeedback)

Attachments

(1 file)

Tab opened from other private browse tabs should become a private browse one.
Because a private tab is in private browse session, so a new tab opened from them should be continued private browse session.
Blocks: pb
This bug means also that the child tab of private tab should change its color.
Keywords: ux-userfeedback
OS: Mac OS X → Android
Hardware: x86 → ARM
Duplicate of this bug: 801694
Summary: Tab opened from other private browse tabs should become a private browse one → PBM - Tab opened from other private browse tabs should become a private browse one
Which version is the target of this bug?
I think this feature need to enable Firefox Android per-tab private browsing by default...
tracking-fennec: --- → ?
Assignee: nobody → bnicholson
Status: NEW → ASSIGNED
Attachment #690970 - Flags: review?(mark.finkle)
Comment on attachment 690970 [details] [diff] [review]
Use private state of parent when opening new tabs

I'm assuming the only time we want this code to kick in is when the user clicks a link in a private tab and that link opens a new tab. Other methods of opening a URL in a new tab are explicit (menus or external intents) so we should let those open "naturally".

The changes look like they should do the trick, but we should still be on the look out for regressions. There are lots of ways to open in windows/tabs.
Attachment #690970 - Flags: review?(mark.finkle) → review+
(In reply to Mark Finkle (:mfinkle) from comment #5)
> I'm assuming the only time we want this code to kick in is when the user
> clicks a link in a private tab and that link opens a new tab. Other methods
> of opening a URL in a new tab are explicit (menus or external intents) so we
> should let those open "naturally".

Mark, I agree your opinion.

I have 1 question. Does "menus" in your comment means the page context menu?
If it's so, I think it is good that opening a tab from the page context menu of private tab should open as private tab. (I think Firefox Android need to behave like Firefox Desktop, in this point.)

I agree that opening a URL from external intents should be open as normal tab.
(In reply to Tetsuharu OHZEKI [:saneyuki_s] from comment #6)
> (In reply to Mark Finkle (:mfinkle) from comment #5)
> > I'm assuming the only time we want this code to kick in is when the user
> > clicks a link in a private tab and that link opens a new tab. Other methods
> > of opening a URL in a new tab are explicit (menus or external intents) so we
> > should let those open "naturally".
> 
> Mark, I agree your opinion.
> 
> I have 1 question. Does "menus" in your comment means the page context menu?
> If it's so, I think it is good that opening a tab from the page context menu
> of private tab should open as private tab. (I think Firefox Android need to
> behave like Firefox Desktop, in this point.)

Yes, "menus" mean context menus. In Fennec we have both: "Open in New Tab" and "Open in New Private Tab" so both cases are covered. Fennec uses per-tab private browsing, desktop will use per-window private browsing. I believe that gives Fennec slightly different "rules" for interactions.
(In reply to Mark Finkle (:mfinkle) from comment #7)
> Yes, "menus" mean context menus. In Fennec we have both: "Open in New Tab"
> and "Open in New Private Tab" so both cases are covered. Fennec uses per-tab
> private browsing, desktop will use per-window private browsing. I believe
> that gives Fennec slightly different "rules" for interactions.

Oops! I missed Fennec has two menus, "Open in New Tab" and "Open in New Private Tab".
I agree their menu can cover both cases. And it should be better on per-tab private browsing if Fennec have them.

Thank you for the explanation.
https://hg.mozilla.org/mozilla-central/rev/1d6f209c9067
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Verified fixed on:
- build: Firefox for Android 20.0a1(2012-12-18)
- device: Samsung Galaxy Nexus 
- OS: Android 4.1.2
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.