801723 - nsJSIID::HasInstance shouldn't assume that any WebIDL binding object that's nsISupports has classinfo

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Because it just ain't true.

Comment 1

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Attachment: WebIDL binding objects may not have classinfo even if they're nsISupports.

Comment 2

[Boris Zbarsky [:bzbarsky, bz on IRC]]

I think we need this on branches, in general....

Comment 3

[Boris Zbarsky [:bzbarsky, bz on IRC]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95be4274988c

Comment 4

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Comment on attachment 671484 [details] [diff] [review]
WebIDL binding objects may not have classinfo even if they're nsISupports.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Initial WebIDL bindings landing
User impact if declined: Null-deref crashes that content can trigger
Testing completed (on m-c, etc.): Passes tests and all that.
Risk to taking this patch (and alternatives if risky): Low risk: just a null-check
String or UUID changes made by this patch: None

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/95be4274988c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/58ba9dc8ea5a
https://hg.mozilla.org/releases/mozilla-beta/rev/e581c5d6a288