Closed Bug 801723 Opened 13 years ago Closed 13 years ago

nsJSIID::HasInstance shouldn't assume that any WebIDL binding object that's nsISupports has classinfo

Categories

(Core :: XPConnect, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19
Tracking Status
firefox17 + fixed
firefox18 + fixed
firefox19 + fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

Because it just ain't true.
I think we need this on branches, in general....
Attachment #671484 - Flags: review?(peterv) → review+
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla19
Comment on attachment 671484 [details] [diff] [review] WebIDL binding objects may not have classinfo even if they're nsISupports. [Approval Request Comment] Bug caused by (feature/regressing bug #): Initial WebIDL bindings landing User impact if declined: Null-deref crashes that content can trigger Testing completed (on m-c, etc.): Passes tests and all that. Risk to taking this patch (and alternatives if risky): Low risk: just a null-check String or UUID changes made by this patch: None
Attachment #671484 - Flags: approval-mozilla-beta?
Attachment #671484 - Flags: approval-mozilla-aurora?
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Attachment #671484 - Flags: approval-mozilla-beta?
Attachment #671484 - Flags: approval-mozilla-beta+
Attachment #671484 - Flags: approval-mozilla-aurora?
Attachment #671484 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: