80178 - Enable OCSP in PSM 2.0.

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[David P. Drinan]

Enable OCSP in PSM 2.0.

Comment 1

[David P. Drinan]

Attachment: Patch for review.

Comment 2

[David P. Drinan]

Adding mcgreer to cc-list.

Need review from Javi, Terry or Ian.

Comment 3

[Ian McGreer]

r=mcgreer

Comment 4

[David P. Drinan]

Adding blizzard to cc-list.

blizzard, please super-review.

Thanks.

Comment 5

[Christopher Blizzard (:blizzard)]

Can you please make functions like ocsp_compare_entries() static member
functions of a utility class or part of nsOCSPResponder or at least use
consistent function naming style?  Putting c-style this_is_a_function with
StudlyCaps naming is ugly.

+  nsISupportsArray *array = (nsISupportsArray*)aArg;

Please use NS_STATIC_CAST()

+  if (sec_rv != SECSuccess) {
+    goto loser;
+  }
[...]
+loser:
+  return NS_OK;

Shouldn't 'loser' return an NS_ERROR_SOMETHING instead of NS_OK?

Fix those or respond and you have an sr=blizzard.  Thanks!

Comment 6

[David P. Drinan]

Implemented the above suggestions from blizzard.

Comment 7

[John Unruh]

*** Bug 76488 has been marked as a duplicate of this bug. ***

Comment 8

[Christopher Blizzard (:blizzard)]

If you've fixed the problems you should be ready to check in.

Comment 9

[David P. Drinan]

Fix checked in.

Comment 10

[John Unruh]

Verified with the 5/22 Netscape 6 WinNT build.