Open Bug 801858 Opened 12 years ago Updated 2 years ago

get rid of null checks for DocAccessible::mDocumentNode

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect

Tracking

()

People

(Reporter: dholbert, Unassigned)

References

(Blocks 1 open bug)

Details

Per Bug 801808 comment 4, DocAccessible can assume its "mDocument" pointer is now non-null.
Daniel, do you remember what kind of assertion and where should be added? It doesn't look clear from mentioned bug comment.
Blocks: cleana11y
Flags: needinfo?(dholbert)
I think comment 0 meant to say "per Bug 801808 comment 3" (not 4). Sorry for the confusion.

Bug 801808 made us assert that mPresShell is null (and drop a null-check for it).  Apparently we used to have similarly useless null checks for "mDocument" pointer, so I spun off this bug for opportunistic cleanup.

It looks like bug 812970 renamed the "mDocument" pointer to "mDocumentNode", and it looks like we've removed some null-checks of it over the years, so maybe there's nothing left to be done here.  Feel free to close/morph as you see fit.
Flags: needinfo?(dholbert)
agreed, we still have a bunch of null checks for DocAccessible::mDocumentNode, which we can removed, morphing the bug.
Summary: DocAccessible should probably assume & assert that it has a non-null document → get rid of null checks for DocAccessible::mDocumentNode
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.