Closed Bug 801915 Opened 7 years ago Closed 7 years ago

IonMonkey: Handle JSOP_IN

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: sstangl, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [ion:p2])

Attachments

(1 file)

Dromaeo's CSSQuery-Dojo test attempts to compile a function but fails for lack on Ion JSOP_IN support. Welp.
Sounds like this could matter for performance, if just to compile the surrounding function.
Whiteboard: [ion:p2]
Attachment #672147 - Flags: review? → review?(jdemooij)
Comment on attachment 672147 [details] [diff] [review]
Implement JSOP_IN using callVM.

Review of attachment 672147 [details] [diff] [review]:
-----------------------------------------------------------------

Nice. Both TM and JM+TI (bug 664824) have/had a fast path for "int32 in dense array". Can you file a follow-up bug so that we don't forget about it?
Attachment #672147 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/d3a655f609ca
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Comment on attachment 672147 [details] [diff] [review]
Implement JSOP_IN using callVM.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 786160
User impact if declined: Significant performance regression on benchmarks
Testing completed (on m-c, etc.): Yes
Risk to taking this patch (and alternatives if risky): Very little, might expose existing JIT bugs by nature of allowing more to JIT.
String or UUID changes made by this patch:
Attachment #672147 - Flags: approval-mozilla-aurora?
Comment on attachment 672147 [details] [diff] [review]
Implement JSOP_IN using callVM.

Approving it on aurora as it has a significant perf impact
Attachment #672147 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.