801982 - Scratchpad doesn't show confirmation dialog after opening a file

Status: RESOLVED FIXED

(DevTools Graveyard :: Scratchpad, defect)

Description

[Anton Kovalyov (:anton)]

How to reproduce:

 * Open Scratchpad
 * Load a new file
 * Change its contents
 * Try closing Scratchpad by clicking on X (not a menu item)

Expected result: a dialog asking you to save changes.
Actual result: Scratchpad closes and your changes are lost.

Comment 1

[Anton Kovalyov (:anton)]

Attachment: Removed _skipClosePrompt line and added a regression test

Comment 2

[Anton Kovalyov (:anton)]

Attachment: Removed all _skipClosePrompt instances and added a regression test

Heather (correctly) noticed that we don't need _skipClosePrompt at all since window.close doesn't trigger a "close" event. I tested manually and run all Scratchpad tests (on Ubuntu).

Comment 3

[Heather Arthur [:harth]]

https://hg.mozilla.org/integration/fx-team/rev/0c63519f8e41

Comment 4

[Heather Arthur [:harth]]

Backed out for failing scratchpad test on Win XP debug:

https://hg.mozilla.org/integration/fx-team/rev/f39343285fc1

Comment 5

[Anton Kovalyov (:anton)]

Attachment: Removed all _skipClosePrompt instances and added a regression test

Updated patch to prevent potential race condition when testing |Scratchpad.onClose|. This method now accepts an optional callback, just like |Scratchpad.close|.

Try build for this patch: https://tbpl.mozilla.org/?tree=Try&rev=f5a74664ba5f (no related oranges).

Comment 6

[Heather Arthur [:harth]]

Comment on attachment 672879 [details] [diff] [review]
Removed all _skipClosePrompt instances and added a regression test

Looks good, I like the code removal.

Comment 7

[Heather Arthur [:harth]]

https://hg.mozilla.org/integration/fx-team/rev/4067355bbc56

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4067355bbc56