Closed
Bug 802007
Opened 13 years ago
Closed 13 years ago
Remove unneeded Mac-only memory reporters.
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
7.02 KB,
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
Back when we didn't use jemalloc on Mac, it was useful to have
Mac-specific "heap-allocated" and "heap-unused" memory reporters. But now
they're dead code unless you're in a --disable-jemalloc build (along with
the "zone0" reporters), and they are a hindrance to DMD builds.
| Assignee | ||
Comment 1•13 years ago
|
||
This patch removes the rarely-used Mac-specific memory reporters. This
allows us to also remove HAVE_HEAP_ALLOCATED_REPORTERS and
HAVE_EXPLICIT_REPORTER, and just use HAVE_JEMALLOC_STATS instead.
Attachment #671725 -
Flags: review?(justin.lebar+bug)
Comment 2•13 years ago
|
||
Comment on attachment 671725 [details] [diff] [review]
Remove unneeded Mac-only memory reporters.
Did we ever un-support 10.5? We don't have jemalloc there (because of OS bugs).
http://www.mozilla.org/en-US/firefox/system-requirements.html still shows 10.5.
That's my only concern here. r=me if we don't have to worry about 10.5.
Attachment #671725 -
Flags: review?(justin.lebar+bug) → review+
Comment 3•13 years ago
|
||
lsblakk tells me we unsupported 10.5 in FF17, so we're good here.
| Assignee | ||
Comment 4•13 years ago
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•