802063 - [Settings] Won't remember the Data Connection status after reboot

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P2)

Description

[John Shih]

## Environment :
Otoro phone, build 2012-10-16
Build info: 
* "gaia" revision= 6a6c070293c6cd404fc7d3d7afece401dd114419
* "gecko" revision= add440caf2f26a55f86e456502689709a9fed143

## Repro :
1. Launch the settings
2. Set the APN setting and turn on the Data Connection
3. See the "3G" shows on the status bar
4. Reboot the device
5. After boot, see the status bar (still can see the "3G" there)
6. Go the settings to check the status of Data Connection 

## Expected:
* See the status is on

## Actual:
* The status is off

Comment 1

[Shian-Yow Wu [:swu]]

I cannot reproduce this issue.  Do you mean the Data Connection in settings is turned off after reboot, but you still can see the 3G connected in status bar?

Comment 2

[Andreas Gal :gal]

Related to this I filed a bug to enable data by default. Right now its off by default.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I found this in logcat after launching settings:

10-16 16:02:14.589: E/GeckoConsole(105): [JavaScript Error: "value is not an object" {file: "jar:file:///system/b2g/omni.ja!/components/SettingsManager.js" line: 114}]

Not sure if it's related.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I was able to reproduce this issue on the same nightly build as John Shih

Comment 5

[John Shih]

Shian-Yow: yes, that is exactly what I mean

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Looks like the Status bar UI is correct, you are still connected there; the bug is that the settings will reset to off when you restart the settings app.

You can reproduce the issue by killing the settings app and launching the app; you will still have mobile network connection and data transfer, the settings app just shows the wrong thing.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

## Environment :
Otoro phone, build 2012-10-17
Taken from default.xml in b2g-distro: 
* "platform_build" revision= 0d6d050bc37d3167cc82a1885fd7660456bb0f4e
* "gaia" revision= e3efbd0411218762cf9a62278bf58ee513ff331f 
* "releases-mozilla-aurora" revision= 03b0489737178628de48fa29ba71b2f3cedc3172
* "gonk-misc" revision= 6214475b7cdf4d78c2f51769bad96503aa0fa3bf

Comment 8

[Alex Keybl [:akeybl]]

Marking blocking-basecamp+ because our users will be using the data connection setting regularly and will be confused by this. Marking as a P2 since this doesn't block any immediate testing.

Comment 9

[Shian-Yow Wu [:swu]]

We found the issue only reproducible on some Otoro devices, and it was fixed by a manual factory reset (rm -r /data/local) on problematic device and flashing image again.  It could be the device contains some outdated settings.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This happens because one of the value of a setting is /null/ and mozSettings tries to have fun with it.

Comment 11

[Shian-Yow Wu [:swu]]

This patch works for me.  Are we going to land it?

Comment 12

[John Shih]

I need to test it when this patch is landing
Because I still met this bug with my own build

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d208c273a705

Comment 14

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Oups. I didn't meant to close it.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d208c273a705

Should this have a test?

Comment 16

[John Shih]

It doesn't happen anymore

test with 
2012-10-26
gaia master : 2c50025f7a7ce6f2e653c0e75ef7bd505d823cb8
gecko : c9173078c6a84ed9a423868090cf57f593247f53

Comment 17

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d782479f2838