Make "macintosh" the canonical name of its encoding, not "x-mac-roman"

RESOLVED FIXED in mozilla19

Status

()

enhancement
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

Trunk
mozilla19
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

csmacintosh, mac, macintosh, and x-mac-roman are all labels for one encoding in both Gecko and WebKit.  The canonical name for that encoding (as returned by .characterSet) is macintosh per spec and in IE/WebKit, but we make it x-mac-roman.  It seems sensible to change.
Posted patch PatchSplinter Review
Turns out we already had an XXX for this, too.  Try: https://tbpl.mozilla.org/?tree=Try&rev=b9bf030e721c
Assignee: nobody → ayg
Status: NEW → ASSIGNED
Attachment #671779 - Flags: review?(smontagu)
Comment on attachment 671779 [details] [diff] [review]
Patch

Please rename test_decode_x_mac_roman.js and test_encode_x_mac_roman.js.
Attachment #671779 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/07ccbbd6fbb0

(In reply to Masatoshi Kimura [:emk] from comment #2)
> Please rename test_decode_x_mac_roman.js and test_encode_x_mac_roman.js.

I did this in the patch I pushed.
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/07ccbbd6fbb0
https://hg.mozilla.org/mozilla-central/rev/353c63026073
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.