802069 - Make "macintosh" the canonical name of its encoding, not "x-mac-roman"

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

csmacintosh, mac, macintosh, and x-mac-roman are all labels for one encoding in both Gecko and WebKit.  The canonical name for that encoding (as returned by .characterSet) is macintosh per spec and in IE/WebKit, but we make it x-mac-roman.  It seems sensible to change.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

Turns out we already had an XXX for this, too.  Try: https://tbpl.mozilla.org/?tree=Try&rev=b9bf030e721c

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 671779 [details] [diff] [review]
Patch

Please rename test_decode_x_mac_roman.js and test_encode_x_mac_roman.js.

Comment 3

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07ccbbd6fbb0

(In reply to Masatoshi Kimura [:emk] from comment #2)
> Please rename test_decode_x_mac_roman.js and test_encode_x_mac_roman.js.

I did this in the patch I pushed.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/07ccbbd6fbb0
https://hg.mozilla.org/mozilla-central/rev/353c63026073

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/07ccbbd6fbb0
https://hg.mozilla.org/mozilla-central/rev/353c63026073