Closed Bug 802115 Opened 7 years ago Closed 7 years ago

The top sites section thumbnails in about:home are cut off

Categories

(Firefox for Android :: General, defect)

19 Branch
ARM
Android
defect
Not set

Tracking

()

RESOLVED INVALID

People

(Reporter: paul.feher, Unassigned)

References

Details

(Keywords: regression)

Attachments

(3 files)

Attached image Screenshot
Firefox 19.0a1 (2012-10-16)
Device: Samsung Galaxy R
OS: Android 2.3.4

Steps to reproduce:
1. Go about:home
2. Tap the sync button from the page
3. Rotate the device in landscape mode
4. Select cancel to return to about:home page
5. Look at the thumbnails

Expected result:
The thumbnails should be properly displayed.

Actual result:
The thumbnails are cut off like in the attached screenshot.
Blocks: 786380
Keywords: regression
Strange. I saw this on some of my devices and intentionally added some code [1] to invalidate the crop when the device was rotated. It looks like the version of Android running on the Galaxy R? must not correctly call onConfigurationChanged.

[1]http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/AboutHomeContent.java.in#609
Attached patch PatchSplinter Review
I'll have to get a GalaxyR to test this. I have noticed that just drawing thumbs on my Gingerbread phone seems slightly slower. So the idea here is that maybe we just disable the rounded corners on those devices. I'll post a screenshot.
Attached image Patch
Attachment #671924 - Flags: review?(mark.finkle)
Comment on attachment 671923 [details] [diff] [review]
Patch

I bet you'll enjoy reviewing this more.
Attachment #671923 - Flags: review?(mark.finkle)
Attachment #671924 - Attachment is patch: false
Attachment #671924 - Attachment mime type: text/plain → image/png
Attachment #671924 - Flags: review?(mark.finkle)
Comment on attachment 671923 [details] [diff] [review]
Patch

>I'll have to get a GalaxyR to test this. I have noticed that just drawing thumbs on my
>Gingerbread phone seems slightly slower. So the idea here is that maybe we just disable
>the rounded corners on those devices. I'll post a screenshot.

Slower before or after the patch?

>         protected boolean drawChild(Canvas canvas, View child, long drawingTime) {
>+            if (android.os.Build.VERSION.SDK_INT < android.os.Build.VERSION_CODES.HONEYCOMB) {
>+                return super.drawChild(canvas, child, drawingTime);
>+            }
>             // draw a shadow behind the thumbnail

nit: add a blank line after the new if block

Also, given the performance regressions from the initial landing, should we be considering turning off rounded corners for all devices?
Attachment #671923 - Flags: review?(mark.finkle) → review+
Aaron, you made this blocking the wrong bug, it seems.
Blocks: 787765
No longer blocks: 786380
We turned these off for all devices in bug 793721.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.