802121 - [System] Configure cell broadcast service through operator-variant software.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[José Antonio Olivera Ortega [:jaoo]]

Cell broadcast service (SMS-CB) must be pre-configured by default. This feature is necessary for device certification. For example, we must enable channel 50
notifications by default for phones sold in Brazil. The same is
happening for other countries in LATAM (e.g. Chile).

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Attachment: WIP

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github WIP branch: https://github.com/jaoo/gaia/tree/bug802121

Pointer to Github WIP branch: https://github.com/jaoo/gaia/tree/bug802121

Comment 3

[Alex Keybl [:akeybl]]

Milestoning for C2 (deadline of 12/10), as this meets the criteria of "known P2 bugs found before or during C1".

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github WIP branch: https://github.com/jaoo/gaia/tree/802121

Just move the work to another branch.

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

WIP patch updated after landing bug 804960.

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Vicamo, this work is ready to review/land. How about we land what I have now and deal with any bugfixes later? So long as the feature doesn't introduce any risk (I would say it doesn't introduce much risk), there should be no reason not to land this IMHO.

Comment 7

[Dietrich Ayala (:dietrich)]

If there's no risk to landing this before CB lands, I would say to do so.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #6)
> Vicamo, this work is ready to review/land. How about we land what I have now
> and deal with any bugfixes later? So long as the feature doesn't introduce
> any risk (I would say it doesn't introduce much risk), there should be no
> reason not to land this IMHO.

José you may want to ask for review on a patch in order to be able to land anything. Can you attach something to this bug?

Comment 9

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Vivien Nicolas (:vingtetun) from comment #8)
> José you may want to ask for review on a patch in order to be able to land
> anything. Can you attach something to this bug?

I was waiting for a response from Vicamo since the CB platform support has not landed yet and he is working on it. Maybe we could go ahead and land this but Vicamo's opinion would be appreciated. If you guys are ok with landing it I'll make the PR and request review at Kaze as I've commented today with it.

Comment 10

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/6750

I'll request review at kaze once the cell broadcast support gets landed.

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #10)
> Created attachment 687037 [details]
> Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/6750
> 
> I'll request review at kaze once the cell broadcast support gets landed.

Is there any side effect if we land the Gaia patch before the platform? If not I would let's try to merge it asap :)

Comment 12

[José Antonio Olivera Ortega [:jaoo]]

Nope, I have even tested this work without CB patches landed and it doesn't broke anything. I'll request review at Kaze and land it later.

Comment 13

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 687037 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/6750

Hey Kaze, could make a review of that work please? Thx!

Comment 14

[Fabien Cazenave [:kaze]]

Comment on attachment 687037 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/6750

looks good :)

Comment 15

[Fabien Cazenave [:kaze]]

José-Antonio, please squash your commits so we can merge them. Thanks!

Comment 16

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/6978951a40d21254fe618209a764a7337b0f7ee4