802137 - [WiFi] WEP key length should be 5 or 13

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, enhancement)

Description

[Masashi Honma]

The WEP key length is defined in [1] "11.2.2.1 WEP overview" section.
The section defines 40-bit and 104-bit key. So I made this restriction.

See PR #5702 for patch.

[1] IEEE Std 802.11-2012

Comment 1

[Jason Smith [:jsmith]]

This appears to already be fixed.

Comment 2

[Masashi Honma]

> This appears to already be fixed.

No, this is not fixed but my PR was just closed.
I checked it now with lates Gaia and Gecko.
I think this should be fixed.

Comment 3

[Masashi Honma]

Attachment: Pull Request

Comment 4

[Masashi Honma]

Attachment: Pull Request

Comment 5

[Masashi Honma]

To check WEP key length is important feature but currently not implemented.

I implemented it for settings and FTE.

Comment 6

[Fernando Campo (:fcampo)]

Patch looks good to me, but I want to bring people to the conversation, as apparently they were involved on the original discussion on https://github.com/mozilla-b2g/gaia/pull/5702

Personally, I never used WEP, so not sure if the 5 or 13 char restriction would be nice to apply, or a blocker. If that's the case, please set the corresponding flags, as it would speed up the process now that we're focused on tef+ bugs

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I don't know much about WEP key restriction. mrbkap did the original wifi backend so let's see if he knows more.

Comment 8

[Fabien Cazenave [:kaze]]

I don’t know much about WEP key restriction either, but though I like the way this patch is written I’m afraid that a strict five-or-thirteen length control would break existing cases and it doesn’t bring such a big UX improvement otherwise.

I’ll rely on Blake’s opinion for this patch.

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

I'm not sure that I'm much help here either. I *thought* that in addition to hex keys of 5 and 13 characters, some routers (maybe old Apple internet sharing via wifi?) also allowed passphrases of semi-arbitrary lengths, but I can't verify that.

Comment 10

[Masashi Honma]

Blake Kaplan,

> hex keys of 5 and 13 characters

Right, I have modified the Pull Request to support HEX key input.
I have tested with ASCII 5, 13 and HEX 10, 26 key.

> semi-arbitrary lengths

Indeed, some STA/AP vendor supports 16 and 29 ASCII characters (32, 58 HEX characters) as a vendor specific functionality.
And I agree exsiting user will use these length.
So, I have modified the Pull Request to support these.

But now we could not use 32 HEX characters even if without this patch.
Because gecko/dom/wifi/WifiWorker.js#isWepHexKey() doesn't support it.
If somebody will need this key length, we should modify isWepHexKey() out of this bug.

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Vincent,
Could you provide some inputs here? We are not so sure about the WEP key restriction. Thanks.

Comment 12

[Vincent Chang[:vchang][changyihsin]]

I am fine with this restriction. The term WEP by itself refers to either
WEP-40(ASCII 5 and HEX 10) or WEP-104(ASCII 13 or HEX 26) in IEEE 80211 spec.

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 750866 [details]
Pull Request

Masashi, thank you for the patch. Based on the comments above, it looks good to me. r=me.

Comment 14

[Masashi Honma]

Arthur Chen, thanks for your review.

Fernando Campo, is there any comment ?

Comment 15

[Fernando Campo (:fcampo)]

Comment on attachment 750866 [details]
Pull Request

No comments at all, the code looks good, and you already have r+ from people who knows more than me about WEP, so you're good to go.


Do you have permissions to merge or do you need me to do so?

Comment 16

[Masashi Honma]

Fernando Campo,

> Do you have permissions to merge or do you need me to do so?

No, I don't have permissions to merge.
If you can, merge my patch.

Comment 17

[Fernando Campo (:fcampo)]

Merged on master https://github.com/mozilla-b2g/gaia/commit/5d5013bd9c51e27fa90b54751e85070d76465c0c

Thanks Masashi!