Closed
Bug 802223
Opened 12 years ago
Closed 12 years ago
Suppress harfbuzz warning about Unicode functions
Categories
(Core :: Graphics: Text, defect)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: jfkthame, Assigned: jfkthame)
Details
Attachments
(1 file)
|
835 bytes,
patch
|
jtd
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
As we provide our own Unicode callbacks, we don't need harfbuzz's glib-, icu-, or ucdn-based versions. Defining HB_NO_UNICODE_FUNCS will suppress the compile-time warning that it generates because it doesn't find any of these in our build.
Attachment #671910 -
Flags: review?(jdaggett)
|
||
Updated•12 years ago
|
Attachment #671910 -
Flags: review?(jdaggett) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 671910 [details] [diff] [review]
patch, suppress compiler warning that isn't relevant in our build
Review of attachment 671910 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/harfbuzz/src/Makefile.in
@@ +86,5 @@
> include $(topsrcdir)/config/rules.mk
>
> DEFINES += -DPACKAGE_VERSION="\"moz\""
> DEFINES += -DPACKAGE_BUGREPORT="\"http://bugzilla.mozilla.org/\""
> +DEFINES += -DHAVE_OT=1 -DHB_NO_MT -HB_NO_UNICODE_FUNCS
Oops, there's a typo here... that needs to be -DHB_NO_UNICODE_FUNCS, obviously. I'll fix before pushing.
|
|
Assignee | |
Comment 3•12 years ago
|
||
Target Milestone: --- → mozilla19
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•