Suppress harfbuzz warning about Unicode functions

RESOLVED FIXED in mozilla19

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

unspecified
mozilla19
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 671910 [details] [diff] [review]
patch, suppress compiler warning that isn't relevant in our build

As we provide our own Unicode callbacks, we don't need harfbuzz's glib-, icu-, or ucdn-based versions. Defining HB_NO_UNICODE_FUNCS will suppress the compile-time warning that it generates because it doesn't find any of these in our build.
Attachment #671910 - Flags: review?(jdaggett)

Updated

6 years ago
Attachment #671910 - Flags: review?(jdaggett) → review+
(Assignee)

Comment 2

6 years ago
Comment on attachment 671910 [details] [diff] [review]
patch, suppress compiler warning that isn't relevant in our build

Review of attachment 671910 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/harfbuzz/src/Makefile.in
@@ +86,5 @@
>  include $(topsrcdir)/config/rules.mk
>  
>  DEFINES += -DPACKAGE_VERSION="\"moz\""
>  DEFINES += -DPACKAGE_BUGREPORT="\"http://bugzilla.mozilla.org/\""
> +DEFINES += -DHAVE_OT=1 -DHB_NO_MT -HB_NO_UNICODE_FUNCS

Oops, there's a typo here... that needs to be -DHB_NO_UNICODE_FUNCS, obviously. I'll fix before pushing.
https://hg.mozilla.org/mozilla-central/rev/83d4508b92d3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.