802279 - border-image-* computed style should clamp negative calc()

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/mozilla-central/rev/978e9865042f changed a few nullptr to false in nsComputedDOMStyle.cpp.  However, the three properties in question don't accept negative values, so those arguments should actually be |true|.  (I suspect this was a merging error.)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: border-image-* properties should clamp negative calc(). ()

Comment 2

[Kang-Hao (Kenny) Lu [:kennyluck]]

Isn't this clamping supposed to happen at the used value time?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is getComputedStyle(), not computed style.

Comment 4

[Kang-Hao (Kenny) Lu [:kennyluck]]

True. But except certain properties, shouldn't they match by default? I do kind of agree that getComputedStyle() should be more used-value like though.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

getComputedStyle() is the used value, basically.  (CSS 2.0 didn't have the distinction between computed and used; DOM-Level-2-Style was based on CSS 2.0.)

Comment 6

[Jeff Walden [:Waldo]]

Comment on attachment 671951 [details] [diff] [review]
border-image-* properties should clamp negative calc().  ()

rs=me, I was just helping the compiler along to avoid an error, would be nice to have a test if this is at all observable, wish I had time to really investigate to find out...

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2a9a612fa07a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2a9a612fa07a