802396 - Android Service-based updater downloads wrong architecture update package for ARMv6.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Szabolcs Hubai (:xabolcs)]

STR:

0. $ ./adb logcat |grep -e "/GeckoApp" -e "/UpdateService"
1. get an outdated Nightly for Android ARMv6 (for example 2012-10-15 [1])
2. check for update
3. examine the log

> I/GeckoApp(17715): Got message: Update:Check
> I/GeckoApp(17715): Return
> I/UpdateService(16977): next update will be at: Wed Oct 17 02:51:50 GMT+02:00 2012
> I/UpdateService(16977): update available, buildID = 20121016030544
> I/UpdateService(16977): downloading update package
> I/UpdateService(16977): completed update download!
> I/UpdateService(16977): have update package at /mnt/sdcard/Download/fennec-19.0a1.multi.android-arm.apk

4. examine the downloaded apk: 
4.1: it have "lib/armeabi-v7a" directory, instead "lib/armeabi" 
4.2: it's name doesn't have "-armv6" suffix.

5. if You install the downloaded update, the updated Nightly will hang (as expected): "force close / wait" popup appears




[1]: https://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2012/10/2012-10-15-03-06-12-mozilla-central-android-armv6/fennec-19.0a1.multi.android-arm-armv6.apk

Comment 1

[Szabolcs Hubai (:xabolcs)]

Attachment: ARMv6 Nightly updated to ARMv7 couldn't load mozglue

ADB logcat-ed start-up of updated Nightly.

> E/GeckoAppShell(18721): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
> E/GeckoAppShell(18721): java.lang.UnsatisfiedLinkError: Couldn't load mozglue: findLibrary returned null

Of course, this (v7 binary can't run on v6) is not a surprise.

Comment 2

[Szabolcs Hubai (:xabolcs)]

Forgot to mention the hardware.

Memory: 280M
Hardware: Samsung Galaxy Mini (GT-S5570)


> $ busybox free
>               total         used         free       shared      buffers
>   Mem:       286620       268568        18052            0          740
>  Swap:            0            0            0
> Total:       286620       268568        18052
> 
> $ cat /proc/cpuinfo
> Processor       : ARMv6-compatible processor rev 5 (v6l)
> BogoMIPS        : 599.65
> Features        : swp half thumb fastmult vfp edsp java
> CPU implementer : 0x41
> CPU architecture: 6TEJ
> CPU variant     : 0x1
> CPU part        : 0xb36
> CPU revision    : 5
> 
> Hardware        : GT-S5570 Board
> Revision        : 0003
> Serial          : xxxxxxxxxxxxxxxxxxxxx

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Use the correct update url for Android ARMv6

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87d06105d0ba

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/87d06105d0ba

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 672333 [details] [diff] [review]
Use the correct update url for Android ARMv6

[Approval Request Comment]
No risk, fixes updater for ARMv6

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 672333 [details] [diff] [review]
Use the correct update url for Android ARMv6

Product expressed a desire to possibly use the FF17 updater off of the ESR branch. Can we uplift there as well?

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 672333 [details] [diff] [review]
Use the correct update url for Android ARMv6

[Approval Request Comment]
Low-risk, makes updater work for ARMv6 on Beta

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d9d6459ef4dd

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/releases/mozilla-beta/rev/d784c1e0cfad

Comment 11

[[e-mail] (:bhearsum)]

I'm pretty sure this caused updates for armv7 to break :(. bug 806343 has some analysis.