802415 - [AccessFu] Introduce better feedback when switching tabs and focusing on content area.

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Report virtual cursor position on selected tab when tab changes, or when focus moves to content area.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 672086 [details] [diff] [review]
Report virtual cursor position on selected tab when tab changes, or when focus moves to content area.

Review of attachment 672086 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/jsat/AccessFu.jsm
@@ +198,5 @@
> +        this._focused = JSON.parse(aData);
> +        if (this._focused) {
> +          let mm = Utils.getMessageManager(Utils.getCurrentBrowser(this.chromeWin));
> +          mm.sendAsyncMessage('AccessFu:VirtualCursor',
> +                              {action: 'whereIsIt', move: true});

What is the 'move' for?

@@ +236,5 @@
> +      {
> +        if (this._focused) {
> +          let mm = Utils.getMessageManager(Utils.getCurrentBrowser(this.chromeWin));
> +          // We delay this for half a second so the awesomebar could close,
> +          // and we could use the current coordinates for the content item.

Blarg. How about adding a comment:
// XXX TODO figure out how to avoid magic wait here.

::: accessible/src/jsat/content-script.js
@@ +53,5 @@
>        break;
>      case 'moveToPoint':
>        moved = vc.moveToPoint(rule, details.x, details.y, true);
>        break;
> +    case 'whereIsIt':

This grew on me (another option might be 'whereAreYou').

@@ +55,5 @@
>        moved = vc.moveToPoint(rule, details.x, details.y, true);
>        break;
> +    case 'whereIsIt':
> +      if (!forwardMessage(vc, aMessage)) {
> +        if (!vc.position && aMessage.json.move)

Why do you check move?

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to David Bolter [:davidb] from comment #2)
> Comment on attachment 672086 [details] [diff] [review]
> Report virtual cursor position on selected tab when tab changes, or when
> focus moves to content area.
> 
> Review of attachment 672086 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/src/jsat/AccessFu.jsm
> @@ +198,5 @@
> > +        this._focused = JSON.parse(aData);
> > +        if (this._focused) {
> > +          let mm = Utils.getMessageManager(Utils.getCurrentBrowser(this.chromeWin));
> > +          mm.sendAsyncMessage('AccessFu:VirtualCursor',
> > +                              {action: 'whereIsIt', move: true});
> 
> What is the 'move' for?
> 

If the virtual cursor is not any anything, move it to the first object in the docu using the Simple rule.

> @@ +236,5 @@
> > +      {
> > +        if (this._focused) {
> > +          let mm = Utils.getMessageManager(Utils.getCurrentBrowser(this.chromeWin));
> > +          // We delay this for half a second so the awesomebar could close,
> > +          // and we could use the current coordinates for the content item.
> 
> Blarg. How about adding a comment:
> // XXX TODO figure out how to avoid magic wait here.
> 

Sure thing.

> ::: accessible/src/jsat/content-script.js
> @@ +53,5 @@
> >        break;
> >      case 'moveToPoint':
> >        moved = vc.moveToPoint(rule, details.x, details.y, true);
> >        break;
> > +    case 'whereIsIt':
> 
> This grew on me (another option might be 'whereAreYou').
> 

Glad!

> @@ +55,5 @@
> >        moved = vc.moveToPoint(rule, details.x, details.y, true);
> >        break;
> > +    case 'whereIsIt':
> > +      if (!forwardMessage(vc, aMessage)) {
> > +        if (!vc.position && aMessage.json.move)
> 
> Why do you check move?

If move is true, move to first object in document when no vc position is set.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

> > @@ +55,5 @@
> > >        moved = vc.moveToPoint(rule, details.x, details.y, true);
> > >        break;
> > > +    case 'whereIsIt':
> > > +      if (!forwardMessage(vc, aMessage)) {
> > > +        if (!vc.position && aMessage.json.move)
> > 
> > Why do you check move?
> 
> If move is true, move to first object in document when no vc position is set.

OK I assume a whereIsIt with move not true might happen sometime?

Comment 5

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a79ae6b84547

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a79ae6b84547

Comment 7

[Marco Zehe (:MarcoZ)]

Verified fixed in the 2012-10-20 nightly build. Together with bug 802280, this causes nice feedback when switching tabs.

Comment 8

[Marco Zehe (:MarcoZ)]

Comment on attachment 672086 [details] [diff] [review]
Report virtual cursor position on selected tab when tab changes, or when focus moves to content area.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): OOP a11y reorg for B2G.
User impact if declined: Users won't hear any feedback, and get inaccurate representations, when switching tabs.
Testing completed (on m-c, etc.): Yes.
Risk to taking this patch (and alternatives if risky): None known.
String or UUID changes made by this patch: None. This bug must be taken along with bug 802280.

Comment 9

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/0273a51a9ebc