802465 - Cant stream mp4 video on device

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[Dale Harvey (:daleharvey)]

Attempting to play a video stream from youtube gives me 

E/GeckoConsole(  106): [JavaScript Warning: "Media resource http://o-o---preferred---sn-aigeznld---v8---lscache8.c.youtube.com/videoplayback?upn=dBqsUaT9-ds&sparams=cp%2Cgcr%2Cid%2Cip%2Cipbits%2Citag%2Cratebypass%2Csource%2Cupn%2Cexpire&fexp=902904%2C916600%2C927200%2C904824%2C914011%2C927104%2C922401%2C920704%2C912806%2C927201%2C913546%2C913556%2C925109%2C919003%2C912706%2C900816%2C911112&ms=au&expire=1350466405&itag=22&ipbits=8&gcr=gb&sver=3&ratebypass=yes&mt=1350442991&ip=87.194.154.176&mv=m&source=youtube&key=yt1&cp=U0hURVRRVF9FT0NONF9MS1hFOm56WWRsbjczMno3&id=313d4385c420d0eb&newshard=yes&signature=0B0F31B8008E2F7F7D8694FA2A3512CD2B16C809.3FBEDBBEE8CE46AA91D4F79D42FFF29BECB9FF1E could not be decoded." {file: "app://video.gaiamobile.org/index.html" line: 0}]

curling the url gives me a valid video/mp4 stream

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Log from device

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Stream output

Comment 3

[Dale Harvey (:daleharvey)]

The attachments are for the stream:

http://o-o---preferred---sn-aigeznld---v5---lscache8.c.youtube.com/videoplayback?upn=1-hRG4oV3ro&sparams=cp%2Cid%2Cip%2Cipbits%2Citag%2Cratebypass%2Csource%2Cupn%2Cexpire&fexp=902904%2C916600%2C927200%2C904824%2C914011%2C927104%2C922401%2C920704%2C912806%2C927201%2C913546%2C913556%2C925109%2C919003%2C912706%2C900816%2C911112&key=yt1&expire=1350468168&itag=22&ipbits=8&sver=3&ratebypass=yes&mt=1350444612&ip=87.194.154.176&mv=m&source=youtube&ms=au&cp=U0hURVRRVl9LUkNONF9MS1pCOnF6WWRsbjc1OWYw&id=6c17ee34bcdb5893&newshard=yes&signature=134429E5026CD8C43C0C03517420352E31CFC954.4C3ADA71D2F235D0CE68A8594B24690DB20ADBD6

Comment 4

[cajbir (:cajbir)]

Edwin, can you take a look at this and see why it's failing to play?

Comment 5

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: Fix

The problem was that the video was too big. Patch limits the resolution of the video stream we choose.

Comment 6

[[:fabrice] Fabrice Desré]

Comment on attachment 673001 [details] [diff] [review]
Fix

Review of attachment 673001 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed

::: b2g/components/YoutubeProtocolHandler.js
@@ +78,5 @@
> +      // itag is an undocumented value which maps to resolution and mimetype
> +      // see https://en.wikipedia.org/wiki/YouTube#Quality_and_codecs
> +      // Ordered from least to most preferred
> +      let recognizedItags = [
> +        "14", // 144p 3GP

This is 17 according to the wikipedia page.

@@ +99,5 @@
>  
>          let index;
> +        if (url && type && ((index = recognizedItags.indexOf(itag)) != -1) &&
> +            index > bestItag) {
> +          uri = url + '&signature=' + (params["sig"] ? params['sig'] : '');

Nit: double quotes everywhere please.

Comment 7

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6b6b9bf38ed2

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6b6b9bf38ed2

Comment 9

[Andrew Overholt [:overholt]]

We can't have this regress.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0f1db1a4a71b

Comment 11

[Mihai Morar, (:MihaiMorar)]

Verified Fixed on FF 18b6 and FF 19b1.  No fail or error found while playing different video streams from Youtube and other Broadcasts.

FF18b6
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:18.0) Gecko/20100101 Firefox/18.0 (20121227074833)
FF 19b1
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:19.0) Gecko/20100101 Firefox/19.0 (20130109111322)