Closed Bug 802465 Opened 7 years ago Closed 7 years ago

Cant stream mp4 video on device

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla19
blocking-basecamp +
Tracking Status
firefox18 --- verified
firefox19 --- verified

People

(Reporter: daleharvey, Assigned: eflores)

References

Details

Attachments

(3 files)

Edwin, can you take a look at this and see why it's failing to play?
Assignee: nobody → eflores
Attached patch FixSplinter Review
The problem was that the video was too big. Patch limits the resolution of the video stream we choose.
Attachment #673001 - Flags: review?(fabrice)
Comment on attachment 673001 [details] [diff] [review]
Fix

Review of attachment 673001 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed

::: b2g/components/YoutubeProtocolHandler.js
@@ +78,5 @@
> +      // itag is an undocumented value which maps to resolution and mimetype
> +      // see https://en.wikipedia.org/wiki/YouTube#Quality_and_codecs
> +      // Ordered from least to most preferred
> +      let recognizedItags = [
> +        "14", // 144p 3GP

This is 17 according to the wikipedia page.

@@ +99,5 @@
>  
>          let index;
> +        if (url && type && ((index = recognizedItags.indexOf(itag)) != -1) &&
> +            index > bestItag) {
> +          uri = url + '&signature=' + (params["sig"] ? params['sig'] : '');

Nit: double quotes everywhere please.
blocking-basecamp: --- → ?
https://hg.mozilla.org/mozilla-central/rev/6b6b9bf38ed2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
We can't have this regress.
blocking-basecamp: ? → +
Summary: Cant stream mp4 video on otoro → Cant stream mp4 video on device
Attachment #673001 - Flags: review?(fabrice) → review+
Verified Fixed on FF 18b6 and FF 19b1.  No fail or error found while playing different video streams from Youtube and other Broadcasts.

FF18b6
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:18.0) Gecko/20100101 Firefox/18.0 (20121227074833)
FF 19b1
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:19.0) Gecko/20100101 Firefox/19.0 (20130109111322)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.