802466 - Youtube stream url requires signature

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[Dale Harvey (:daleharvey)]

Changes to youtubes api require a signature to be provided

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 802466 - Add signature to stream url. r=fabrice

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 672141 [details] [diff] [review]
Bug 802466 - Add signature to stream url. r=fabrice

Review of attachment 672141 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed.

::: b2g/components/YoutubeProtocolHandler.js
@@ +92,5 @@
>  
>          let index;
>          if (url && type && ((index = recognizedTypes.indexOf(type)) != -1) &&
>              index > bestType) {
> +          uri = url + '&signature=' + params['sig'];

we need to guard against params['sig'] being null

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Bug 802466 - Add signature to stream url. r=fabrice

Added null check

Comment 4

[Andrew Overholt [:overholt]]

YouTube is important.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d896a7f47e02

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d896a7f47e02

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/915d0d6c7967