The default bug view has changed. See this FAQ.

don't use software floating point math on ARMv6

RESOLVED FIXED in Firefox 17

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: blassey, Assigned: blassey)

Tracking

unspecified
mozilla19
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox17 fixed, firefox18 fixed, firefox19 fixed, fennec17+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 672305 [details] [diff] [review]
patch

this is OMG slowing us down, I think we just need to make floating point hardware a min system requirement
Attachment #672305 - Flags: review?(khuey)
Comment on attachment 672305 [details] [diff] [review]
patch

Please make the change in the mozconfigs.
Attachment #672305 - Flags: review?(khuey) → review-
(Assignee)

Updated

5 years ago
Attachment #672305 - Flags: review- → review?(khuey)
(In reply to Mike Hommey [:glandium] from comment #1)
> Comment on attachment 672305 [details] [diff] [review]
> patch
> 
> Please make the change in the mozconfigs.

I don't want to. I want this to be the default so that developers will be building the same thing we are shipping
(In reply to Brad Lassey [:blassey] from comment #2)
> (In reply to Mike Hommey [:glandium] from comment #1)
> > Comment on attachment 672305 [details] [diff] [review]
> > patch
> > 
> > Please make the change in the mozconfigs.
> 
> I don't want to. I want this to be the default so that developers will be
> building the same thing we are shipping

The change in build/autoconf/arch.m4 impacts more than developers. Developers already have to add something to do armv6 build, i don't see why it would be a problem for them to add something more.
Comment on attachment 672305 [details] [diff] [review]
patch

Review of attachment 672305 [details] [diff] [review]:
-----------------------------------------------------------------

Make it at least limited to Android.
Attachment #672305 - Flags: review?(khuey) → review-
Without looking at how high up in the configure we need/want this, my suspicion is a change in http://mxr.mozilla.org/comm-central/source/mozilla/mobile/android/confvars.sh would do what brad and glandium want, without being intrusive
Created attachment 672330 [details] [diff] [review]
patch
Assignee: nobody → blassey.bugs
Attachment #672305 - Attachment is obsolete: true
Attachment #672330 - Flags: review?(khuey)
Attachment #672330 - Flags: review?(khuey) → review+
Comment on attachment 672330 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: for some reason (we will investigate) soft float math is killing us on region operations, which is making display list building very slow, which makes panning very slow. Not taking this will make panning slower than we want it to be.
Testing completed (on m-c, etc.): just landed on m-i, should probably get a couple nightlies before uplift
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch: 



https://hg.mozilla.org/integration/mozilla-inbound/rev/c4119fd2fb37
Attachment #672330 - Flags: approval-mozilla-beta?
Attachment #672330 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/c4119fd2fb37
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Triage drive-by, will wait for a couple of nightlies.
Attachment #672330 - Flags: approval-mozilla-beta?
Attachment #672330 - Flags: approval-mozilla-beta+
Attachment #672330 - Flags: approval-mozilla-aurora?
Attachment #672330 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/1bb9cedfb386
https://hg.mozilla.org/releases/mozilla-beta/rev/121213ddf98b
status-firefox17: --- → fixed
status-firefox18: --- → fixed
status-firefox19: --- → fixed

Updated

5 years ago
Keywords: verifyme
QA Contact: kbrosnan
mass remove verifyme requests greater than 4 months old
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.