802658 - strokeText and fillText bug with shadow and translate

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[simonleung]

Attachment: test.html

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:18.0) Gecko/18.0 Firefox/18.0
Build ID: 20121016042009

Steps to reproduce:

Using strokeText/fillText in canvas, with shadow and a translate of the position.



Actual results:

Only half (upper part) of the text "ABCDEFG" shown.

Tested in FF 18, window xp.

Comment 1

[Alice0775 White]

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/3d9424eb6eb4
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120901193714
Bad:
http://hg.mozilla.org/mozilla-central/rev/6c66c3997381
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120902185812
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3d9424eb6eb4&tochange=6c66c3997381


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/476d122c82a6
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120902155712
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/6c66c3997381
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20120902160711
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=476d122c82a6&tochange=6c66c3997381

Regressed by: Bug 781731

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Apply matrix trnsform to shadow temp surface bounds

Comment 3

[Mozilla RelEng Bot]

Try run for 93b1400dc685 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=93b1400dc685
Results (out of 97 total builds):
    exception: 3
    success: 72
    warnings: 17
    failure: 5
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-93b1400dc685

Comment 4

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Part 1: Whitespace fixes

Comment 5

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Part 2: Apply transform to text bounds

Comment 6

[Mozilla RelEng Bot]

Try run for 4307bd191edf is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=4307bd191edf
Results (out of 97 total builds):
    exception: 2
    success: 83
    warnings: 7
    failure: 5
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-4307bd191edf

Comment 7

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Part 2: Apply transform to text bounds v2

Comment 8

[Mozilla RelEng Bot]

Try run for 4307bd191edf is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=4307bd191edf
Results (out of 98 total builds):
    exception: 2
    success: 84
    warnings: 7
    failure: 5
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-4307bd191edf

Comment 9

[Mozilla RelEng Bot]

Try run for 4307bd191edf is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=4307bd191edf
Results (out of 100 total builds):
    exception: 2
    success: 86
    warnings: 7
    failure: 5
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-4307bd191edf

Comment 10

[Bas Schouten (:bas.schouten)]

Comment on attachment 674477 [details] [diff] [review]
Part 2: Apply transform to text bounds v2

Review of attachment 674477 [details] [diff] [review]:
-----------------------------------------------------------------

Nice find.

Comment 11

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d7fc5c44ee2
https://hg.mozilla.org/integration/mozilla-inbound/rev/278e17fa10e7

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1d7fc5c44ee2
https://hg.mozilla.org/mozilla-central/rev/278e17fa10e7

Comment 13

[bhavana bajaj [:bajaj]]

(In reply to :Ms2ger from comment #11)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/1d7fc5c44ee2
> https://hg.mozilla.org/integration/mozilla-inbound/rev/278e17fa10e7

Please nominate for aurora-uplifts once we comfortable with testing/bake-time on m-c.Thanks !

Comment 14

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 674477 [details] [diff] [review]
Part 2: Apply transform to text bounds v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 781731
User impact if declined: Text shadow truncated when transforms applied
Testing completed (on m-c, etc.): on m-c. local testing.
Risk to taking this patch (and alternatives if risky): Low risk and could only affect text shadow because the bounds only used for shadow.
String or UUID changes made by this patch: None.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/88df0b13ff34
https://hg.mozilla.org/releases/mozilla-aurora/rev/4682035751ea

Comment 16

[simonleung]

Attachment: one more test on save state and path

Comment 17

[simonleung]

The text still get truncated even in the first attachment test.html with lower shadowBlur value. i.e.

c.shadowBlur=5;
....

Comment 18

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

If so, please file a new bug.

Comment 19

[Paul Silaghi, QA [:pauly]]

Verified fixed using the testcase and based on comment 18.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20100101 Firefox/18.0b4
Aurora 19.0a2 (2012-12-18)