Closed
Bug 802724
Opened 13 years ago
Closed 13 years ago
MobileConnection doesn't QI to nsIObserver
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla19
| Tracking | Status | |
|---|---|---|
| firefox18 | --- | fixed |
People
(Reporter: bent.mozilla, Assigned: mounir)
References
Details
Attachments
(1 file)
|
1.00 KB,
patch
|
bent.mozilla
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Seeing a bunch of QI assertions on B2G shutdown, looks like MobileConnection doesn't QI to nsIObserver.
|
Assignee | |
Comment 1•13 years ago
|
||
I guess that one-liner should do.
|
Reporter | |
Updated•13 years ago
|
Attachment #672729 -
Flags: review?(bent.mozilla) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Target Milestone: --- → mozilla19
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 672729 [details] [diff] [review]
Patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 729173
User impact if declined: broken or unexpected behaviour
Risk to taking this patch (and alternatives if risky): unless we had code magically working because of that breakage, none
String or UUID changes made by this patch: none
Attachment #672729 -
Flags: approval-mozilla-aurora?
|
|
Assignee | |
Comment 4•13 years ago
|
||
Forgot to say, this patch has to land on aurora for B2G (and it's a B2G-only feature).
|
||
Comment 5•13 years ago
|
||
Comment on attachment 672729 [details] [diff] [review]
Patch
b2g-only feature, approving for Aurora.
Attachment #672729 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
|
|
||
Comment 7•13 years ago
|
||
status-firefox18:
--- → fixed
Blocks: 805168
You need to log in
before you can comment on or make changes to this bug.
Description
•