Closed Bug 802724 Opened 8 years ago Closed 8 years ago

MobileConnection doesn't QI to nsIObserver

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19
Tracking Status
firefox18 --- fixed

People

(Reporter: bent.mozilla, Assigned: mounir)

References

Details

Attachments

(1 file)

Seeing a bunch of QI assertions on B2G shutdown, looks like MobileConnection doesn't QI to nsIObserver.
Attached patch PatchSplinter Review
I guess that one-liner should do.
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #672729 - Flags: review?(bent.mozilla)
Attachment #672729 - Flags: review?(bent.mozilla) → review+
Comment on attachment 672729 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 729173
User impact if declined: broken or unexpected behaviour
Risk to taking this patch (and alternatives if risky): unless we had code magically working because of that breakage, none
String or UUID changes made by this patch: none
Attachment #672729 - Flags: approval-mozilla-aurora?
Forgot to say, this patch has to land on aurora for B2G (and it's a B2G-only feature).
Comment on attachment 672729 [details] [diff] [review]
Patch

b2g-only feature, approving for Aurora.
Attachment #672729 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/2030c47a8e69
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.